Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies that reference more than one directory level of traversal (../) in their ESM specifiers do not resolve correctly #820

Closed
1 of 5 tasks
thescientist13 opened this issue Dec 11, 2021 · 0 comments · Fixed by #832
Assignees
Labels
bug Something isn't working CLI question Further information is requested v0.24.0
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Dec 11, 2021

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

As part of working on a project, came across a Stencil generated WC that had references to a dependency that did an export of sibling files like so

export {
  ...
} from '../client/index.js';

This tracks as we only check for ./ in our code 🤫

Details

In addition to this support, I also found cases where I would specifically need to check for a "barrel" / index.js file at a directory for bare imports like this?

import { BUILD, NAMESPACE } from '@stencil/core/internal/app-data';
@thescientist13 thescientist13 added bug Something isn't working question Further information is requested CLI labels Dec 11, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone Dec 11, 2021
@thescientist13 thescientist13 self-assigned this Dec 11, 2021
@thescientist13 thescientist13 changed the title dependencies that reference more than one directory level do not resolve correctly dependencies that reference more than one directory level of traversal (../) in their ESM specifiers do not resolve correctly Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI question Further information is requested v0.24.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant