You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While most graphs we encounter are topologically sorted, and while ONNX IR spec specifies that to be the case, for compliance, ( see https://github.com/onnx/onnx/blob/main/docs/IR.md#graphs ), however, we do encounter non topologically sorted graphs on occasion, and furthermore both ORT and Netron seem to support them.
As we build the migraphx IR, we can add nodes before they are defined (and keep a list of undefined ops)... eventually they will be defined! Each new node we encounter, we will first check to see if it is in the "undefined" list.
The text was updated successfully, but these errors were encountered:
For invalid onnx file, we can write a python script to sort them or we could have a flag to pass to the onnx parser that will sort the nodes first, but we dont want that flag enabled by default because it can change the order of the nodes if they are already sorted.
While most graphs we encounter are topologically sorted, and while ONNX IR spec specifies that to be the case, for compliance, ( see https://github.com/onnx/onnx/blob/main/docs/IR.md#graphs ), however, we do encounter non topologically sorted graphs on occasion, and furthermore both ORT and Netron seem to support them.
As we build the migraphx IR, we can add nodes before they are defined (and keep a list of undefined ops)... eventually they will be defined! Each new node we encounter, we will first check to see if it is in the "undefined" list.
The text was updated successfully, but these errors were encountered: