From 1f1786e7b2f88ea4b44d576fcb45fa29f9de7152 Mon Sep 17 00:00:00 2001 From: Lanling Xu Date: Wed, 10 Aug 2022 11:32:58 +0800 Subject: [PATCH 1/2] FEA: Add model and dataset name to log file --- recbole/utils/logger.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/recbole/utils/logger.py b/recbole/utils/logger.py index 3cc583db3..0e2e42cdd 100644 --- a/recbole/utils/logger.py +++ b/recbole/utils/logger.py @@ -79,7 +79,7 @@ def init_logger(config): ensure_dir(model_name) config_str = "".join([str(key) for key in config.final_config_dict.values()]) md5 = hashlib.md5(config_str.encode(encoding="utf-8")).hexdigest()[:6] - logfilename = "{}/{}-{}.log".format(config["model"], get_local_time(), md5) + logfilename = "{}/{}-{}-{}-{}.log".format(config["model"], config["model"], config["dataset"], get_local_time(), md5) logfilepath = os.path.join(LOGROOT, logfilename) From de297b0cc9e860ee51ea388405e05552129d29dd Mon Sep 17 00:00:00 2001 From: Sherry-XLL Date: Wed, 10 Aug 2022 03:34:41 +0000 Subject: [PATCH 2/2] Format Python code according to PEP8 --- recbole/utils/logger.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/recbole/utils/logger.py b/recbole/utils/logger.py index 0e2e42cdd..fdf4ca45f 100644 --- a/recbole/utils/logger.py +++ b/recbole/utils/logger.py @@ -79,7 +79,9 @@ def init_logger(config): ensure_dir(model_name) config_str = "".join([str(key) for key in config.final_config_dict.values()]) md5 = hashlib.md5(config_str.encode(encoding="utf-8")).hexdigest()[:6] - logfilename = "{}/{}-{}-{}-{}.log".format(config["model"], config["model"], config["dataset"], get_local_time(), md5) + logfilename = "{}/{}-{}-{}-{}.log".format( + config["model"], config["model"], config["dataset"], get_local_time(), md5 + ) logfilepath = os.path.join(LOGROOT, logfilename)