Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Either make config required in Documentable::To::HTML::Wrapper or add reasonable defaults #66

Closed
JJ opened this issue Nov 24, 2019 · 1 comment

Comments

@JJ
Copy link
Contributor

JJ commented Nov 24, 2019

The config file is actually required only in these two lines:

https://github.com/perl6/Documentable/blob/334637080b6488f4972712fb86d3f173d9a5d982/lib/Documentable/To/HTML/Wrapper.pm6#L42-L43

We need either to add reasonable defaults for both, or make it required

@JJ JJ changed the title Either make configrequired in Documentable::To::HTML::Wrapper or add reasonable defaults Either make config required in Documentable::To::HTML::Wrapper or add reasonable defaults Nov 29, 2019
@JJ JJ added the enhancement New feature or request label Nov 29, 2019
@antoniogamiz
Copy link
Collaborator

antoniogamiz commented Jul 6, 2020

Required here:

die X::Documentable::Config::InvalidConfig.new(:msg("'title-page' entry missing"))
unless %!config<title-page>;
die X::Documentable::Config::InvalidConfig.new(:msg("'pod-root-path' entry missing"))
unless %!config<pod-root-path>;
$!title-page = %!config<title-page>;
$!pod-root-path = %!config<pod-root-path>;

Anyway, they have been removed from the wrapper as attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants