You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GetBaseEvolution improperly passes a parent's form to a child if the parent has a different form index and there is no intervening pre-evolution that matches the child's form. To illustrate, Alolan Exeggutor will breed an Exeggcute with form 2, but Alolan Raichu will breed a Pichu of form 1 (note that this works properly since Pikachu form 2 aka Surfing Pikachu is a cosmetic form).
Really, the underlying issue is that GetBaseEvolution scales very poorly as new Pokemon and variant forms are added to Polished. The safest and most scalable fix is to explicitly list as part of egg moves which Pokemon is the base evolution. This is less memory efficient than calculating base evolution dynamically but more sustainable. Note that GetNewBaseExp would need a rework as well, since it cares about what stage a target Pokemon is.
The text was updated successfully, but these errors were encountered:
GetBaseEvolution
improperly passes a parent's form to a child if the parent has a different form index and there is no intervening pre-evolution that matches the child's form. To illustrate, Alolan Exeggutor will breed an Exeggcute with form 2, but Alolan Raichu will breed a Pichu of form 1 (note that this works properly since Pikachu form 2 aka Surfing Pikachu is a cosmetic form).Really, the underlying issue is that
GetBaseEvolution
scales very poorly as new Pokemon and variant forms are added to Polished. The safest and most scalable fix is to explicitly list as part of egg moves which Pokemon is the base evolution. This is less memory efficient than calculating base evolution dynamically but more sustainable. Note thatGetNewBaseExp
would need a rework as well, since it cares about what stage a target Pokemon is.The text was updated successfully, but these errors were encountered: