From e749ede6ffa2b14821385f6285f4595d1eba2051 Mon Sep 17 00:00:00 2001 From: luis Date: Wed, 3 Jul 2019 11:01:57 -0400 Subject: [PATCH 1/5] #6551 Renaming Observable.onErrorResumeNext to Observable.onErrorResumeWith, removing unnecessary cast from null tests, and updating Observable.onErrorResumeWith's JavaDoc to reference correct parameter name, renamed test classes since the distinctions in their names are no longer necessary. --- src/main/java/io/reactivex/Observable.java | 12 ++++++------ .../operators/observable/ObservableDelayTest.java | 2 +- ...est.java => ObservableOnErrorResumeNextTest.java} | 2 +- ...est.java => ObservableOnErrorResumeWithTest.java} | 12 ++++++------ .../io/reactivex/observable/ObservableNullTests.java | 4 ++-- 5 files changed, 16 insertions(+), 16 deletions(-) rename src/test/java/io/reactivex/internal/operators/observable/{ObservableOnErrorResumeNextViaFunctionTest.java => ObservableOnErrorResumeNextTest.java} (99%) rename src/test/java/io/reactivex/internal/operators/observable/{ObservableOnErrorResumeNextViaObservableTest.java => ObservableOnErrorResumeWithTest.java} (96%) diff --git a/src/main/java/io/reactivex/Observable.java b/src/main/java/io/reactivex/Observable.java index e7f0f694ab..f6de4c980f 100644 --- a/src/main/java/io/reactivex/Observable.java +++ b/src/main/java/io/reactivex/Observable.java @@ -10126,10 +10126,10 @@ public final Observable onErrorResumeNext(Function * By default, when an ObservableSource encounters an error that prevents it from emitting the expected item to * its {@link Observer}, the ObservableSource invokes its Observer's {@code onError} method, and then quits - * without invoking any more of its Observer's methods. The {@code onErrorResumeNext} method changes this - * behavior. If you pass another ObservableSource ({@code resumeSequence}) to an ObservableSource's - * {@code onErrorResumeNext} method, if the original ObservableSource encounters an error, instead of invoking its - * Observer's {@code onError} method, it will instead relinquish control to {@code resumeSequence} which + * without invoking any more of its Observer's methods. The {@code onErrorResumeWith} method changes this + * behavior. If you pass another ObservableSource ({@code next}) to an ObservableSource's + * {@code onErrorResumeWith} method, if the original ObservableSource encounters an error, instead of invoking its + * Observer's {@code onError} method, it will instead relinquish control to {@code next} which * will invoke the Observer's {@link Observer#onNext onNext} method if it is able to do so. In such a case, * because no ObservableSource necessarily invokes {@code onError}, the Observer may never know that an error * happened. @@ -10138,7 +10138,7 @@ public final Observable onErrorResumeNext(Function *
Scheduler:
- *
{@code onErrorResumeNext} does not operate by default on a particular {@link Scheduler}.
+ *
{@code onErrorResumeWith} does not operate by default on a particular {@link Scheduler}.
* * * @param next @@ -10149,7 +10149,7 @@ public final Observable onErrorResumeNext(Function onErrorResumeNext(final ObservableSource next) { + public final Observable onErrorResumeWith(final ObservableSource next) { ObjectHelper.requireNonNull(next, "next is null"); return onErrorResumeNext(Functions.justFunction(next)); } diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableDelayTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableDelayTest.java index 360758c0da..f5340e6c7a 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableDelayTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableDelayTest.java @@ -876,7 +876,7 @@ public void accept(Throwable throwable) throws Exception { latch.countDown(); } }) - .onErrorResumeNext(Observable.empty()) + .onErrorResumeWith(Observable.empty()) .subscribe(); latch.await(); diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextViaFunctionTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextTest.java similarity index 99% rename from src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextViaFunctionTest.java rename to src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextTest.java index 4e24254fd1..68ff5f77b1 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextViaFunctionTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextTest.java @@ -32,7 +32,7 @@ import io.reactivex.schedulers.Schedulers; import io.reactivex.testsupport.*; -public class ObservableOnErrorResumeNextViaFunctionTest { +public class ObservableOnErrorResumeNextTest { @Test public void resumeNextWithSynchronousExecution() { diff --git a/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextViaObservableTest.java b/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeWithTest.java similarity index 96% rename from src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextViaObservableTest.java rename to src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeWithTest.java index c207aff76a..95e4a3b54f 100644 --- a/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeNextViaObservableTest.java +++ b/src/test/java/io/reactivex/internal/operators/observable/ObservableOnErrorResumeWithTest.java @@ -28,7 +28,7 @@ import io.reactivex.schedulers.Schedulers; import io.reactivex.testsupport.TestHelper; -public class ObservableOnErrorResumeNextViaObservableTest { +public class ObservableOnErrorResumeWithTest { @Test public void resumeNext() { @@ -37,7 +37,7 @@ public void resumeNext() { TestObservable f = new TestObservable(upstream, "one", "fail", "two", "three"); Observable w = Observable.unsafeCreate(f); Observable resume = Observable.just("twoResume", "threeResume"); - Observable observable = w.onErrorResumeNext(resume); + Observable observable = w.onErrorResumeWith(resume); Observer observer = TestHelper.mockObserver(); observable.subscribe(observer); @@ -79,7 +79,7 @@ public String apply(String s) { } }); - Observable observable = w.onErrorResumeNext(resume); + Observable observable = w.onErrorResumeWith(resume); Observer observer = TestHelper.mockObserver(); @@ -112,7 +112,7 @@ public void subscribe(Observer t1) { }); Observable resume = Observable.just("resume"); - Observable observable = testObservable.onErrorResumeNext(resume); + Observable observable = testObservable.onErrorResumeWith(resume); Observer observer = TestHelper.mockObserver(); observable.subscribe(observer); @@ -134,7 +134,7 @@ public void subscribe(Observer t1) { }); Observable resume = Observable.just("resume"); - Observable observable = testObservable.subscribeOn(Schedulers.io()).onErrorResumeNext(resume); + Observable observable = testObservable.subscribeOn(Schedulers.io()).onErrorResumeWith(resume); Observer observer = TestHelper.mockObserver(); TestObserver to = new TestObserver(observer); @@ -194,7 +194,7 @@ public void run() { public void backpressure() { TestObserver to = new TestObserver(); Observable.range(0, 100000) - .onErrorResumeNext(Observable.just(1)) + .onErrorResumeWith(Observable.just(1)) .observeOn(Schedulers.computation()) .map(new Function() { int c; diff --git a/src/test/java/io/reactivex/observable/ObservableNullTests.java b/src/test/java/io/reactivex/observable/ObservableNullTests.java index aace11648a..fb1e9968e8 100644 --- a/src/test/java/io/reactivex/observable/ObservableNullTests.java +++ b/src/test/java/io/reactivex/observable/ObservableNullTests.java @@ -1700,7 +1700,7 @@ public void ofTypeNull() { @Test(expected = NullPointerException.class) public void onErrorResumeNextFunctionNull() { - just1.onErrorResumeNext((Function>)null); + just1.onErrorResumeNext(null); } @Test(expected = NullPointerException.class) @@ -1715,7 +1715,7 @@ public Observable apply(Throwable e) { @Test(expected = NullPointerException.class) public void onErrorResumeNextObservableNull() { - just1.onErrorResumeNext((Observable)null); + just1.onErrorResumeWith(null); } @Test(expected = NullPointerException.class) From 9359c2e80398d78322dffe7db08c30c30add5425 Mon Sep 17 00:00:00 2001 From: luis Date: Wed, 3 Jul 2019 11:14:54 -0400 Subject: [PATCH 2/5] #6551 Renaming Maybe.onErrorResumeNext(MaybeSource) to Maybe.onErrorResumeWith(MaybeSource), renamed some of the affected unit tests, and updated JavaDoc. --- src/main/java/io/reactivex/Maybe.java | 4 ++-- .../internal/operators/maybe/MaybeOnErrorXTest.java | 6 +++--- src/test/java/io/reactivex/maybe/MaybeTest.java | 12 ++++++------ 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/main/java/io/reactivex/Maybe.java b/src/main/java/io/reactivex/Maybe.java index c3665995c4..fb6d94ac9d 100644 --- a/src/main/java/io/reactivex/Maybe.java +++ b/src/main/java/io/reactivex/Maybe.java @@ -3732,7 +3732,7 @@ public final Maybe onErrorComplete(final Predicate predica * encountered. *
*
Scheduler:
- *
{@code onErrorResumeNext} does not operate by default on a particular {@link Scheduler}.
+ *
{@code onErrorResumeWith} does not operate by default on a particular {@link Scheduler}.
*
* * @param next @@ -3744,7 +3744,7 @@ public final Maybe onErrorComplete(final Predicate predica @CheckReturnValue @NonNull @SchedulerSupport(SchedulerSupport.NONE) - public final Maybe onErrorResumeNext(final MaybeSource next) { + public final Maybe onErrorResumeWith(final MaybeSource next) { ObjectHelper.requireNonNull(next, "next is null"); return onErrorResumeNext(Functions.justFunction(next)); } diff --git a/src/test/java/io/reactivex/internal/operators/maybe/MaybeOnErrorXTest.java b/src/test/java/io/reactivex/internal/operators/maybe/MaybeOnErrorXTest.java index 5349eaed5e..c3b58c7434 100644 --- a/src/test/java/io/reactivex/internal/operators/maybe/MaybeOnErrorXTest.java +++ b/src/test/java/io/reactivex/internal/operators/maybe/MaybeOnErrorXTest.java @@ -193,7 +193,7 @@ public MaybeSource apply(Maybe v) throws Exception { @Test public void onErrorNextDispose() { - TestHelper.checkDisposed(PublishProcessor.create().singleElement().onErrorResumeNext(Maybe.just(1))); + TestHelper.checkDisposed(PublishProcessor.create().singleElement().onErrorResumeWith(Maybe.just(1))); } @Test @@ -201,7 +201,7 @@ public void onErrorNextDoubleOnSubscribe() { TestHelper.checkDoubleOnSubscribeMaybe(new Function, MaybeSource>() { @Override public MaybeSource apply(Maybe v) throws Exception { - return v.onErrorResumeNext(Maybe.just(1)); + return v.onErrorResumeWith(Maybe.just(1)); } }); } @@ -209,7 +209,7 @@ public MaybeSource apply(Maybe v) throws Exception { @Test public void onErrorNextIsAlsoError() { Maybe.error(new TestException("Main")) - .onErrorResumeNext(Maybe.error(new TestException("Secondary"))) + .onErrorResumeWith(Maybe.error(new TestException("Secondary"))) .to(TestHelper.testConsumer()) .assertFailureAndMessage(TestException.class, "Secondary"); } diff --git a/src/test/java/io/reactivex/maybe/MaybeTest.java b/src/test/java/io/reactivex/maybe/MaybeTest.java index 199511e48a..8ffbde5c07 100644 --- a/src/test/java/io/reactivex/maybe/MaybeTest.java +++ b/src/test/java/io/reactivex/maybe/MaybeTest.java @@ -3199,9 +3199,9 @@ public Throwable get() { } @Test - public void onErrorResumeNextEmpty() { + public void onErrorResumeWithEmpty() { Maybe.empty() - .onErrorResumeNext(Maybe.just(1)) + .onErrorResumeWith(Maybe.just(1)) .test() .assertNoValues() .assertNoErrors() @@ -3209,18 +3209,18 @@ public void onErrorResumeNextEmpty() { } @Test - public void onErrorResumeNextValue() { + public void onErrorResumeWithValue() { Maybe.just(1) - .onErrorResumeNext(Maybe.empty()) + .onErrorResumeWith(Maybe.empty()) .test() .assertNoErrors() .assertValue(1); } @Test - public void onErrorResumeNextError() { + public void onErrorResumeWithError() { Maybe.error(new RuntimeException("some error")) - .onErrorResumeNext(Maybe.empty()) + .onErrorResumeWith(Maybe.empty()) .test() .assertNoValues() .assertNoErrors() From 72a20aa8cf8e2a88777ae1b016454ab6da549833 Mon Sep 17 00:00:00 2001 From: luis Date: Wed, 3 Jul 2019 11:36:16 -0400 Subject: [PATCH 3/5] #6551 Renaming Single.onErrorResumeNext(Single) to Single.onErrorResumeWith(Single), renamed an affected unit test, updated JavaDoc, and removed redundant casts. --- src/main/java/io/reactivex/Single.java | 8 ++++---- .../internal/operators/single/SingleDelayTest.java | 2 +- .../internal/operators/single/SingleMiscTest.java | 4 ++-- .../internal/operators/single/SingleOnErrorXTest.java | 8 ++++---- src/test/java/io/reactivex/single/SingleNullTests.java | 8 ++++---- 5 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/main/java/io/reactivex/Single.java b/src/main/java/io/reactivex/Single.java index a05ffb4567..f092e4f943 100644 --- a/src/main/java/io/reactivex/Single.java +++ b/src/main/java/io/reactivex/Single.java @@ -3207,9 +3207,9 @@ public final Single onErrorReturnItem(final T value) { *

* By default, when a Single encounters an error that prevents it from emitting the expected item to * its {@link SingleObserver}, the Single invokes its SingleObserver's {@code onError} method, and then quits - * without invoking any more of its SingleObserver's methods. The {@code onErrorResumeNext} method changes this + * without invoking any more of its SingleObserver's methods. The {@code onErrorResumeWith} method changes this * behavior. If you pass another Single ({@code resumeSingleInCaseOfError}) to a Single's - * {@code onErrorResumeNext} method, if the original Single encounters an error, instead of invoking its + * {@code onErrorResumeWith} method, if the original Single encounters an error, instead of invoking its * SingleObserver's {@code onError} method, it will instead relinquish control to {@code resumeSingleInCaseOfError} which * will invoke the SingleObserver's {@link SingleObserver#onSuccess onSuccess} method if it is able to do so. In such a case, * because no Single necessarily invokes {@code onError}, the SingleObserver may never know that an error @@ -3219,7 +3219,7 @@ public final Single onErrorReturnItem(final T value) { * encountered. *

*
Scheduler:
- *
{@code onErrorResumeNext} does not operate by default on a particular {@link Scheduler}.
+ *
{@code onErrorResumeWith} does not operate by default on a particular {@link Scheduler}.
*
* * @param resumeSingleInCaseOfError a Single that will take control if source Single encounters an error. @@ -3229,7 +3229,7 @@ public final Single onErrorReturnItem(final T value) { @CheckReturnValue @NonNull @SchedulerSupport(SchedulerSupport.NONE) - public final Single onErrorResumeNext(final Single resumeSingleInCaseOfError) { + public final Single onErrorResumeWith(final Single resumeSingleInCaseOfError) { ObjectHelper.requireNonNull(resumeSingleInCaseOfError, "resumeSingleInCaseOfError is null"); return onErrorResumeNext(Functions.justFunction(resumeSingleInCaseOfError)); } diff --git a/src/test/java/io/reactivex/internal/operators/single/SingleDelayTest.java b/src/test/java/io/reactivex/internal/operators/single/SingleDelayTest.java index ddb52b8ec6..13c23321fd 100644 --- a/src/test/java/io/reactivex/internal/operators/single/SingleDelayTest.java +++ b/src/test/java/io/reactivex/internal/operators/single/SingleDelayTest.java @@ -149,7 +149,7 @@ public void accept(Throwable throwable) throws Exception { latch.countDown(); } }) - .onErrorResumeNext(Single.just("")) + .onErrorResumeWith(Single.just("")) .subscribe(); latch.await(); diff --git a/src/test/java/io/reactivex/internal/operators/single/SingleMiscTest.java b/src/test/java/io/reactivex/internal/operators/single/SingleMiscTest.java index 290d581364..cf9006c152 100644 --- a/src/test/java/io/reactivex/internal/operators/single/SingleMiscTest.java +++ b/src/test/java/io/reactivex/internal/operators/single/SingleMiscTest.java @@ -106,9 +106,9 @@ public void hide() { } @Test - public void onErrorResumeNext() { + public void onErrorResumeWith() { Single.error(new TestException()) - .onErrorResumeNext(Single.just(1)) + .onErrorResumeWith(Single.just(1)) .test() .assertResult(1); } diff --git a/src/test/java/io/reactivex/internal/operators/single/SingleOnErrorXTest.java b/src/test/java/io/reactivex/internal/operators/single/SingleOnErrorXTest.java index aa5a4a03ea..ab34c726fe 100644 --- a/src/test/java/io/reactivex/internal/operators/single/SingleOnErrorXTest.java +++ b/src/test/java/io/reactivex/internal/operators/single/SingleOnErrorXTest.java @@ -53,7 +53,7 @@ public Integer apply(Throwable e) throws Exception { @Test public void resumeErrors() { Single.error(new TestException("Main")) - .onErrorResumeNext(Single.error(new TestException("Resume"))) + .onErrorResumeWith(Single.error(new TestException("Resume"))) .to(TestHelper.testConsumer()) .assertFailureAndMessage(TestException.class, "Resume"); } @@ -61,7 +61,7 @@ public void resumeErrors() { @Test public void resumeDispose() { TestHelper.checkDisposed(Single.error(new TestException("Main")) - .onErrorResumeNext(Single.just(1))); + .onErrorResumeWith(Single.just(1))); } @Test @@ -69,7 +69,7 @@ public void resumeDoubleOnSubscribe() { TestHelper.checkDoubleOnSubscribeSingle(new Function, SingleSource>() { @Override public SingleSource apply(Single s) throws Exception { - return s.onErrorResumeNext(Single.just(1)); + return s.onErrorResumeWith(Single.just(1)); } }); } @@ -77,7 +77,7 @@ public SingleSource apply(Single s) throws Exception { @Test public void resumeSuccess() { Single.just(1) - .onErrorResumeNext(Single.just(2)) + .onErrorResumeWith(Single.just(2)) .test() .assertResult(1); } diff --git a/src/test/java/io/reactivex/single/SingleNullTests.java b/src/test/java/io/reactivex/single/SingleNullTests.java index 9d633647e1..b023df769b 100644 --- a/src/test/java/io/reactivex/single/SingleNullTests.java +++ b/src/test/java/io/reactivex/single/SingleNullTests.java @@ -709,13 +709,13 @@ public void onErrorReturnValueNull() { } @Test(expected = NullPointerException.class) - public void onErrorResumeNextSingleNull() { - error.onErrorResumeNext((Single)null); + public void onErrorResumeWithSingleNull() { + error.onErrorResumeWith(null); } @Test(expected = NullPointerException.class) - public void onErrorResumeNextFunctionNull() { - error.onErrorResumeNext((Function>)null); + public void onErrorResumeNextNull() { + error.onErrorResumeNext(null); } @Test From f9fe7ff1461ce442345e03d5f4ee574215f9f1af Mon Sep 17 00:00:00 2001 From: luis Date: Wed, 3 Jul 2019 11:41:52 -0400 Subject: [PATCH 4/5] #6551 Changing Single.onErrorResumeWith parameter from Single to SingleSource --- src/main/java/io/reactivex/Single.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/io/reactivex/Single.java b/src/main/java/io/reactivex/Single.java index f092e4f943..0350920ebb 100644 --- a/src/main/java/io/reactivex/Single.java +++ b/src/main/java/io/reactivex/Single.java @@ -3229,7 +3229,7 @@ public final Single onErrorReturnItem(final T value) { @CheckReturnValue @NonNull @SchedulerSupport(SchedulerSupport.NONE) - public final Single onErrorResumeWith(final Single resumeSingleInCaseOfError) { + public final Single onErrorResumeWith(final SingleSource resumeSingleInCaseOfError) { ObjectHelper.requireNonNull(resumeSingleInCaseOfError, "resumeSingleInCaseOfError is null"); return onErrorResumeNext(Functions.justFunction(resumeSingleInCaseOfError)); } From 8329dc74cf4808000d3b54341b2b0dbbbdc7c4bc Mon Sep 17 00:00:00 2001 From: luis Date: Wed, 3 Jul 2019 12:03:56 -0400 Subject: [PATCH 5/5] #6551 Renaming Flowable.onErrorResumeNext(Publisher) to Flowable.onErrorResumeWith(Publisher), renaming some affected tests, deleted duplicated unit test that arose from being able to remove redundant casts, updated JavaDocs. --- src/main/java/io/reactivex/Flowable.java | 8 ++++---- .../io/reactivex/flowable/FlowableNullTests.java | 13 ++++--------- .../operators/flowable/FlowableDelayTest.java | 2 +- .../FlowableOnErrorResumeNextViaFlowableTest.java | 12 ++++++------ .../flowable/FlowablePublishFunctionTest.java | 2 +- ...xtTckTest.java => OnErrorResumeWithTckTest.java} | 4 ++-- 6 files changed, 18 insertions(+), 23 deletions(-) rename src/test/java/io/reactivex/tck/{OnErrorResumeNextTckTest.java => OnErrorResumeWithTckTest.java} (84%) diff --git a/src/main/java/io/reactivex/Flowable.java b/src/main/java/io/reactivex/Flowable.java index def87d400b..363d334921 100644 --- a/src/main/java/io/reactivex/Flowable.java +++ b/src/main/java/io/reactivex/Flowable.java @@ -12197,9 +12197,9 @@ public final Flowable onErrorResumeNext(Function * By default, when a Publisher encounters an error that prevents it from emitting the expected item to * its {@link Subscriber}, the Publisher invokes its Subscriber's {@code onError} method, and then quits - * without invoking any more of its Subscriber's methods. The {@code onErrorResumeNext} method changes this + * without invoking any more of its Subscriber's methods. The {@code onErrorResumeWith} method changes this * behavior. If you pass another Publisher ({@code resumeSequence}) to a Publisher's - * {@code onErrorResumeNext} method, if the original Publisher encounters an error, instead of invoking its + * {@code onErrorResumeWith} method, if the original Publisher encounters an error, instead of invoking its * Subscriber's {@code onError} method, it will instead relinquish control to {@code resumeSequence} which * will invoke the Subscriber's {@link Subscriber#onNext onNext} method if it is able to do so. In such a case, * because no Publisher necessarily invokes {@code onError}, the Subscriber may never know that an error @@ -12215,7 +12215,7 @@ public final Flowable onErrorResumeNext(Function *
Scheduler:
- *
{@code onErrorResumeNext} does not operate by default on a particular {@link Scheduler}.
+ *
{@code onErrorResumeWith} does not operate by default on a particular {@link Scheduler}.
* * * @param next @@ -12228,7 +12228,7 @@ public final Flowable onErrorResumeNext(Function onErrorResumeNext(final Publisher next) { + public final Flowable onErrorResumeWith(final Publisher next) { ObjectHelper.requireNonNull(next, "next is null"); return onErrorResumeNext(Functions.justFunction(next)); } diff --git a/src/test/java/io/reactivex/flowable/FlowableNullTests.java b/src/test/java/io/reactivex/flowable/FlowableNullTests.java index d25713b362..7ec883493f 100644 --- a/src/test/java/io/reactivex/flowable/FlowableNullTests.java +++ b/src/test/java/io/reactivex/flowable/FlowableNullTests.java @@ -1646,8 +1646,8 @@ public void onBackpressureDropActionNull() { } @Test(expected = NullPointerException.class) - public void onErrorResumeNextFunctionNull() { - just1.onErrorResumeNext((Function>)null); + public void onErrorResumeNextNull() { + just1.onErrorResumeNext(null); } @Test @@ -1669,8 +1669,8 @@ public Publisher apply(Throwable e) { } @Test(expected = NullPointerException.class) - public void onErrorResumeNextPublisherNull() { - just1.onErrorResumeNext((Publisher)null); + public void onErrorResumeWithNull() { + just1.onErrorResumeWith(null); } @Test(expected = NullPointerException.class) @@ -2958,11 +2958,6 @@ public void sampleFlowableNull() { just1.sample(null); } - @Test(expected = NullPointerException.class) - public void onErrorResumeNextFlowableNull() { - just1.onErrorResumeNext((Flowable)null); - } - @SuppressWarnings("unchecked") @Test(expected = NullPointerException.class) public void combineLatestDelayErrorVarargsFunctionReturnsNull() { diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableDelayTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableDelayTest.java index 289729b249..a2d062368c 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableDelayTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableDelayTest.java @@ -928,7 +928,7 @@ public void accept(Throwable throwable) throws Exception { latch.countDown(); } }) - .onErrorResumeNext(Flowable.empty()) + .onErrorResumeWith(Flowable.empty()) .subscribe(); latch.await(); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnErrorResumeNextViaFlowableTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnErrorResumeNextViaFlowableTest.java index 990827876d..5a62ddb651 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnErrorResumeNextViaFlowableTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowableOnErrorResumeNextViaFlowableTest.java @@ -39,7 +39,7 @@ public void resumeNext() { TestObservable f = new TestObservable(s, "one", "fail", "two", "three"); Flowable w = Flowable.unsafeCreate(f); Flowable resume = Flowable.just("twoResume", "threeResume"); - Flowable flowable = w.onErrorResumeNext(resume); + Flowable flowable = w.onErrorResumeWith(resume); Subscriber subscriber = TestHelper.mockSubscriber(); flowable.subscribe(subscriber); @@ -81,7 +81,7 @@ public String apply(String s) { } }); - Flowable flowable = w.onErrorResumeNext(resume); + Flowable flowable = w.onErrorResumeWith(resume); Subscriber subscriber = TestHelper.mockSubscriber(); @@ -114,7 +114,7 @@ public void subscribe(Subscriber t1) { }); Flowable resume = Flowable.just("resume"); - Flowable flowable = testObservable.onErrorResumeNext(resume); + Flowable flowable = testObservable.onErrorResumeWith(resume); Subscriber subscriber = TestHelper.mockSubscriber(); flowable.subscribe(subscriber); @@ -136,7 +136,7 @@ public void subscribe(Subscriber t1) { }); Flowable resume = Flowable.just("resume"); - Flowable flowable = testObservable.subscribeOn(Schedulers.io()).onErrorResumeNext(resume); + Flowable flowable = testObservable.subscribeOn(Schedulers.io()).onErrorResumeWith(resume); Subscriber subscriber = TestHelper.mockSubscriber(); TestSubscriber ts = new TestSubscriber(subscriber, Long.MAX_VALUE); @@ -196,7 +196,7 @@ public void run() { public void backpressure() { TestSubscriber ts = new TestSubscriber(); Flowable.range(0, 100000) - .onErrorResumeNext(Flowable.just(1)) + .onErrorResumeWith(Flowable.just(1)) .observeOn(Schedulers.computation()) .map(new Function() { int c; @@ -226,7 +226,7 @@ public void normalBackpressure() { PublishProcessor pp = PublishProcessor.create(); - pp.onErrorResumeNext(Flowable.range(3, 2)).subscribe(ts); + pp.onErrorResumeWith(Flowable.range(3, 2)).subscribe(ts); ts.request(2); diff --git a/src/test/java/io/reactivex/internal/operators/flowable/FlowablePublishFunctionTest.java b/src/test/java/io/reactivex/internal/operators/flowable/FlowablePublishFunctionTest.java index 7dba80e92e..831f1bae7f 100644 --- a/src/test/java/io/reactivex/internal/operators/flowable/FlowablePublishFunctionTest.java +++ b/src/test/java/io/reactivex/internal/operators/flowable/FlowablePublishFunctionTest.java @@ -326,7 +326,7 @@ public void errorResubscribe() { .publish(new Function, Publisher>() { @Override public Publisher apply(Flowable f) throws Exception { - return f.onErrorResumeNext(f); + return f.onErrorResumeWith(f); } }) .test() diff --git a/src/test/java/io/reactivex/tck/OnErrorResumeNextTckTest.java b/src/test/java/io/reactivex/tck/OnErrorResumeWithTckTest.java similarity index 84% rename from src/test/java/io/reactivex/tck/OnErrorResumeNextTckTest.java rename to src/test/java/io/reactivex/tck/OnErrorResumeWithTckTest.java index 745ca85af8..b50af2f686 100644 --- a/src/test/java/io/reactivex/tck/OnErrorResumeNextTckTest.java +++ b/src/test/java/io/reactivex/tck/OnErrorResumeWithTckTest.java @@ -19,12 +19,12 @@ import io.reactivex.Flowable; @Test -public class OnErrorResumeNextTckTest extends BaseTck { +public class OnErrorResumeWithTckTest extends BaseTck { @Override public Publisher createPublisher(long elements) { return - Flowable.range(0, (int)elements).onErrorResumeNext(Flowable.never()) + Flowable.range(0, (int)elements).onErrorResumeWith(Flowable.never()) ; } }