issue a waring when Items and collectors for a diamond

addresses pytest-dev#8435

Author: RonnyPfannschmidt

src/_pytest/nodes.py

@@ -33,6 +33,7 @@
 from _pytest.outcomes import fail
 from _pytest.pathlib import absolutepath
 from _pytest.store import Store
+from _pytest.warning_types import PytestWarning
 
 if TYPE_CHECKING:
     # Imported here due to circular import.
@@ -601,6 +602,19 @@ class Item(Node):
 
     nextitem = None
 
+    def __init_subclass__(cls):
+        problems = ", ".join(
+            base.__name__ for base in cls.__bases__ if issubclass(base, Collector)
+        )
+        if problems:
+            warnings.warn(
+                f"{cls.__name__} is a Item subclass and should not be a collector.\n"
+                f"however its bases {problems} are collectors\n"
+                "please split the collection and the items into 2 node types\n"
+                "TODO: doc link",
+                PytestWarning,
+            )
+
     def __init__(
         self,
         name,

testing/test_nodes.py

@@ -38,6 +38,16 @@ def test_node_from_parent_disallowed_arguments() -> None:
         nodes.Node.from_parent(None, config=None)  # type: ignore[arg-type]
 
 
+def test_subclassing_node_with_item_warns() -> None:
+
+    with pytest.warns(
+        PytestWarning, match="SoWrong is a Item subclass and should not be a collector"
+    ):
+
+        class SoWrong(nodes.Item, nodes.File):
+            pass
+
+
 @pytest.mark.parametrize(
     "warn_type, msg", [(DeprecationWarning, "deprecated"), (PytestWarning, "pytest")]
 )