Unable to Deactivate Doctors (senaite#141)

* New transition permissions for Doctor

* New states, transitions and formating for Doctor object

* Upgrade step + delete state

* clean import section

* Not allow Analysts, Samplers and Preservers to modify a Doctor

* Fix typo and upgrade step

* Update CHANGES.rst

Author: Pau Soliva

CHANGES.rst

@@ -17,6 +17,7 @@ Changelog
 
 **Fixed**
 
+- #141 Unable to Deactivate Doctors
 - #137 Client reference widget does not work in Add Patient overlay
 - #133 System clearing patient first name on editing patient
 - #132 Autofill Batch field in Sample Add form when Batch defined in request

bika/health/profiles/default/workflows/senaite_health_doctor_workflow/definition.xml

@@ -98,7 +98,7 @@
   <transition transition_id="deactivate" title="Deactivate" new_state="inactive" trigger="USER" before_script="" after_script="" i18n:attributes="title">
     <action url="" category="workflow" icon="">Deactivate</action>
     <guard>
-      <guard-permission>senaite.core: Transition: Deactivate Doctor</guard-permission>
+      <guard-permission>senaite.health: Transition: Deactivate Doctor</guard-permission>
       <guard-expression>python:here.guard_handler("deactivate")</guard-expression>
     </guard>
   </transition>

bika/health/upgrade/v01_02_002.py

@@ -44,6 +44,7 @@ def upgrade(tool):
                                                    version))
 
     # -------- ADD YOUR STUFF BELOW --------
+    setup.runImportStepFromProfile(profile, 'rolemap')
     setup.runImportStepFromProfile(profile, 'workflow')
 
     apply_doctor_permissions_for_clients(portal, ut)
@@ -54,7 +55,7 @@ def upgrade(tool):
 
 def apply_doctor_permissions_for_clients(portal, ut):
     workflow_tool = api.get_tool("portal_workflow")
-    workflow = workflow_tool.getWorkflowById('bika_doctor_workflow')
+    workflow = workflow_tool.getWorkflowById('senaite_health_doctor_workflow')
     catalog = api.get_tool('portal_catalog')
 
     brains = catalog(portal_type='Doctor')