Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header ifdef guard should filter out illegal characters #29

Closed
jgallagher opened this issue Jan 19, 2016 · 2 comments
Closed

Header ifdef guard should filter out illegal characters #29

jgallagher opened this issue Jan 19, 2016 · 2 comments

Comments

@jgallagher
Copy link

The ifdef guard is currently defined as

"#ifndef cheddar_generated_{0}_h"

(likewise for the next line) where {0} is filled in with the header filename. For typical header filenames, this creates preprocessor tokens that look like cheddar_generated_filename.h_h, but . is not a legal preprocessor identifier character (clang under OS X gives a warning about "extra tokens following an identifier", pointing to the .).

@Sean1708
Copy link
Owner

Thanks for letting me know, that should be fixed now and I've done a v0.3.1 release for you. Could you check that it has worked then close this issue if it has please.

@jgallagher
Copy link
Author

Yep, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants