Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TestCase class to prevent import conflicts with PHPUnit's TestCase #1951

Open
staabm opened this issue Mar 6, 2025 · 1 comment
Open
Labels

Comments

@staabm
Copy link
Contributor

staabm commented Mar 6, 2025

Monolog version 3

Write your question here.

today I was stumbling over a problem of wrongly used TestCase class because autocompletion liked monologs class more then the phpunit one.

this remindet me of a similar issue we had in the past with PHPStan: phpstan/phpstan-src#634

do you think monolog could make a similar move and deprecate+rename the monologs' TestCase class so autocompletion in popular IDEs won't accidentally add monologs TestCase class instead of e.g. PHPunits class?

I think most arguments why this is a good idea and actually the root cause is a phpstorm bug was already discussed in the linked PHPStan issue. I think a lot of people would have less problems when this class would be renamed, even though its totally fine because its in a dedicated namespace.

@staabm staabm added the Support label Mar 6, 2025
@staabm
Copy link
Contributor Author

staabm commented Mar 6, 2025

just found a duplicate which already got closed: #1677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant