Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: [java] Relay session factory alters the client's request capabilities for Appium sessions #15372

Open
sbabcoc opened this issue Mar 4, 2025 · 1 comment

Comments

@sbabcoc
Copy link
Contributor

sbabcoc commented Mar 4, 2025

What happened?

This issue was introduced by #14247
These revisions were intended to resolve #14216

The revisions applied to RelaySessionFactory were unnecessary, actually creating a bug instead of resolving one.
The OP reported that he was unable to acquire Appium session from Selenium Grid 4 because the "merge" operation that combines relay node stereotypes with the client's requested capabilities was creating a specification that defined both appium:app and browserName, which is disallowed by Appium.

The issue wasn't in the Selenium Relay implementation; it was in the OP's configuration. The actual fix was to add an additional entry to the [configs] array of his relay configuration. One of the entries should specify browserName and the other should omit it.

The fix for the issue in RelaySessionFactory is to simply revert the changes from #14247

How can we reproduce the issue?

To reproduce this issue, examine the source for **RelaySessionFactory**. The `apply` method includes Appium-specific implementation that unnecessarily alters the client's desired capabilities.

Relevant log output

There is no relevant log output

Operating System

Any

Selenium version

Java 4.23.0

What are the browser(s) and version(s) where you see this issue?

Android Chrome

What are the browser driver(s) and version(s) where you see this issue?

ChromeDriver 128.0.6594.0

Are you using Selenium Grid?

4.23.0

Copy link

github-actions bot commented Mar 4, 2025

@sbabcoc, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant