Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Apothic Spawners and Apothic Enchanting optional dependencies #1486

Open
WFPhantom opened this issue Feb 18, 2025 · 2 comments
Open

make Apothic Spawners and Apothic Enchanting optional dependencies #1486

WFPhantom opened this issue Feb 18, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@WFPhantom
Copy link

I think Apothic Spawners and Apothic Enchanting should be made optional dependecies because, back when Apotheosis was an all in one mod, we had a config to disable modules. There is currently no way to do this.

@Shadows-of-Fire Shadows-of-Fire added the enhancement New feature or request label Mar 6, 2025
@Shadows-of-Fire
Copy link
Owner

It's being considered, though currently Apotheosis makes some assumptions and uses functionality from the smaller modules to operate, so making them optional dependencies isn't straightforward. I'm not entirely certain if I plan to take this route, either.

Apothic Spawners can be trivially kneecapped with a datapack to disable all user-facing functionality, though the same can't be said for Apothic Enchanting. Were there specific things you were looking to have unavailable? It may be better to introduce more knobs in those projects than make them optional here.

@WFPhantom
Copy link
Author

WFPhantom commented Mar 6, 2025

To be honest i was just looking into using Apotheosis and Apothic Enchanting without Apothic Spawners at all, and i just assumed i would suggest being able to make both Spawners and Enchanting optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants