[2.1, 3.0]: Constant SID is deprecated

[dragomano]

Basic Information

This error occurs periodically and is related to the code where the constant is used.

Example:

if (defined('SID') && SID != '')

Steps to reproduce

No response

Expected result

No response

Actual result

No response

Version/Git revision

3.0 Alpha 2

Database Engine

All

Database Version

11.2.2-MariaDB

PHP Version

8.4.1

Logs

No response

Additional Information

No response

[jdarwood007]

I can't find any information about SID being deprecated.

[jdarwood007]

I found it:

Changing the value of the session.use_only_cookies, session.use_trans_sid, session.trans_sid_tags, session.trans_sid_hosts, and session.referer_check INI settings is deprecated. The SID constant is also deprecated.

https://www.php.net/manual/en/migration84.deprecated.php

[jdarwood007]

Looks like they haven't documented it yet: php/doc-en#3872
Even PHP watch didn't document this, which is why I didn't catch it as I tend to read that to know what to look out for.

[tyrsson]

I know the project is using php-cs-fixer but there is more than likely something like this for it.
https://github.com/PHPCompatibility/PHPCompatibility

[live627]

Does anyone know if any search engines such as googlebot accept cookies?

(This question actually is relevant)

[live627]

Got the answer from Gemini or whatever they call it next.

1

[Sesquipedalian]

IIRC, we can just replace SID with session_id() and be done with it.

[jdarwood007]

@live627 I wouldn't trust that answer. Google is known to have its bots parse and execute Javascript and mimic user actions to test its analytics and AdSense (checking if ads only show for bots). Some of that would require passing cookies, as the site may otherwise use a cookie to know whether something is from a bot or not.