Skip to content

Commit 116c57e

Browse files
Merge release/14.0.0 into dev (#422)
* Fix bug #349 typings for Placeholder prop functions render, renderEach, renderEmpty (#350) * Fixes withSitecoreContext typescript definition (#347) * v14.0.0 * [React sample] Cannot read property 'fields' of undefined * [React sample] version fix * v14.0.1 * [Doc] Remove mentioning that Sitecore JSS Forms are not working in headless mode + provide workaround
1 parent 938305e commit 116c57e

File tree

54 files changed

+275
-170
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+275
-170
lines changed

lerna.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@
44
"packages/*",
55
"samples/*"
66
],
7-
"version": "13.2.0"
7+
"version": "14.0.1"
88
}

packages/sitecore-jss-angular-schematics/package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/sitecore-jss-angular-schematics/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@sitecore-jss/sitecore-jss-angular-schematics",
3-
"version": "13.2.0",
3+
"version": "14.0.1",
44
"description": "Scaffolding schematics for Sitecore JSS Angular apps",
55
"scripts": {
66
"build": "tsc -p tsconfig.json",

packages/sitecore-jss-angular/package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/sitecore-jss-angular/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@sitecore-jss/sitecore-jss-angular",
3-
"version": "13.2.0",
3+
"version": "14.0.1",
44
"description": "",
55
"scripts": {
66
"build": "ng-packagr -p ng-package.json",
@@ -51,7 +51,7 @@
5151
"rxjs": "^6.5.3"
5252
},
5353
"dependencies": {
54-
"@sitecore-jss/sitecore-jss": "^13.2.0"
54+
"@sitecore-jss/sitecore-jss": "^14.0.1"
5555
},
5656
"main": "dist/bundles/sitecore-jss-sitecore-jss-angular.umd.js",
5757
"module": "dist/esm5/sitecore-jss-sitecore-jss-angular.js",

packages/sitecore-jss-cli/package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/sitecore-jss-cli/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@sitecore-jss/sitecore-jss-cli",
3-
"version": "13.2.0",
3+
"version": "14.0.1",
44
"description": "Sitecore JSS command-line",
55
"scripts": {
66
"build": "npm run clean && tsc",
@@ -30,8 +30,8 @@
3030
"url": "https://github.com/sitecore/jss/issues"
3131
},
3232
"dependencies": {
33-
"@sitecore-jss/sitecore-jss-dev-tools": "^13.2.0",
34-
"@sitecore-jss/sitecore-jss-manifest": "^13.2.0",
33+
"@sitecore-jss/sitecore-jss-dev-tools": "^14.0.1",
34+
"@sitecore-jss/sitecore-jss-manifest": "^14.0.1",
3535
"chalk": "^2.4.2",
3636
"cross-spawn": "^7.0.0",
3737
"fs-extra": "^8.1.0",

packages/sitecore-jss-dev-tools/package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/sitecore-jss-dev-tools/package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@sitecore-jss/sitecore-jss-dev-tools",
3-
"version": "13.2.0",
3+
"version": "14.0.1",
44
"description": "Utilities to assist in the development and deployment of Sitecore JSS apps.",
55
"scripts": {
66
"build": "npm run clean && tsc",
@@ -29,9 +29,9 @@
2929
"url": "https://github.com/sitecore/jss/issues"
3030
},
3131
"dependencies": {
32-
"@sitecore-jss/sitecore-jss": "^13.2.0",
33-
"@sitecore-jss/sitecore-jss-manifest": "^13.2.0",
34-
"@sitecore-jss/sitecore-jss-update-package": "^13.2.0",
32+
"@sitecore-jss/sitecore-jss": "^14.0.1",
33+
"@sitecore-jss/sitecore-jss-manifest": "^14.0.1",
34+
"@sitecore-jss/sitecore-jss-update-package": "^14.0.1",
3535
"chokidar": "^3.2.1",
3636
"del": "^5.1.0",
3737
"express": "^4.17.1",

packages/sitecore-jss-forms/package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/sitecore-jss-forms/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@sitecore-jss/sitecore-jss-forms",
3-
"version": "13.2.0",
3+
"version": "14.0.1",
44
"main": "dist/index.js",
55
"scripts": {
66
"build": "npm run clean && tsc",
@@ -42,7 +42,7 @@
4242
"typescript": "^3.6.3"
4343
},
4444
"dependencies": {
45-
"@sitecore-jss/sitecore-jss": "^13.2.0"
45+
"@sitecore-jss/sitecore-jss": "^14.0.1"
4646
},
4747
"description": "",
4848
"types": "types/index.d.ts",

packages/sitecore-jss-manifest/package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/sitecore-jss-manifest/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@sitecore-jss/sitecore-jss-manifest",
3-
"version": "13.2.0",
3+
"version": "14.0.1",
44
"description": "",
55
"main": "dist/index.js",
66
"scripts": {
@@ -25,8 +25,8 @@
2525
"url": "https://github.com/sitecore/jss/issues"
2626
},
2727
"dependencies": {
28-
"@sitecore-jss/sitecore-jss": "^13.2.0",
29-
"@sitecore-jss/sitecore-pipelines": "^13.2.0",
28+
"@sitecore-jss/sitecore-jss": "^14.0.1",
29+
"@sitecore-jss/sitecore-pipelines": "^14.0.1",
3030
"fs-extra": "^8.1.0",
3131
"glob": "^7.1.4",
3232
"import-fresh": "^3.1.0",

packages/sitecore-jss-proxy/package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/sitecore-jss-proxy/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@sitecore-jss/sitecore-jss-proxy",
3-
"version": "13.2.0",
3+
"version": "14.0.1",
44
"description": "Proxy middleware for express.js server.",
55
"main": "dist/index.js",
66
"scripts": {

packages/sitecore-jss-react-forms/package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/sitecore-jss-react-forms/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@sitecore-jss/sitecore-jss-react-forms",
3-
"version": "13.2.0",
3+
"version": "14.0.1",
44
"main": "dist/index.js",
55
"scripts": {
66
"build": "npm run clean && tsc",
@@ -49,7 +49,7 @@
4949
"react-dom": "^16.10.2"
5050
},
5151
"dependencies": {
52-
"@sitecore-jss/sitecore-jss-forms": "^13.2.0",
52+
"@sitecore-jss/sitecore-jss-forms": "^14.0.1",
5353
"prop-types": "^15.7.2"
5454
},
5555
"description": "",

packages/sitecore-jss-react-native/package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/sitecore-jss-react-native/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@sitecore-jss/sitecore-jss-react-native",
3-
"version": "13.2.0",
3+
"version": "14.0.1",
44
"description": "",
55
"main": "dist/index.js",
66
"scripts": {
@@ -26,7 +26,7 @@
2626
"url": "https://github.com/sitecore/jss/issues"
2727
},
2828
"dependencies": {
29-
"@sitecore-jss/sitecore-jss": "^13.2.0",
29+
"@sitecore-jss/sitecore-jss": "^14.0.1",
3030
"prop-types": "^15.7.2",
3131
"react-native-htmlview": "^0.15.0",
3232
"react-native-svg": "^9.13.2",

packages/sitecore-jss-react/package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/sitecore-jss-react/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@sitecore-jss/sitecore-jss-react",
3-
"version": "13.2.0",
3+
"version": "14.0.1",
44
"main": "dist/index.js",
55
"scripts": {
66
"build": "npm run clean && tsc",
@@ -56,7 +56,7 @@
5656
"react-dom": "^16.9.0"
5757
},
5858
"dependencies": {
59-
"@sitecore-jss/sitecore-jss": "^13.2.0",
59+
"@sitecore-jss/sitecore-jss": "^14.0.1",
6060
"prop-types": "^15.7.2",
6161
"style-attr": "^1.3.0"
6262
},

packages/sitecore-jss-react/src/components/Placeholder.test.tsx

+85-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const componentFactory: ComponentFactory = (componentName: string) => {
1515
const components = new Map<string, any>();
1616

1717
// pass otherProps to page-content to test property cascading through the Placeholder
18-
const Home: React.SFC<any> = ({ rendering, ...otherProps }) => (
18+
const Home: React.SFC<any> = ({ rendering, render, renderEach, renderEmpty, ...otherProps }) => (
1919
<div className="home-mock">
2020
<Placeholder name="page-header" rendering={rendering} />
2121
<Placeholder name="page-content" rendering={rendering} {...otherProps} />
@@ -85,6 +85,90 @@ describe('<Placeholder />', () => {
8585
expect(renderedComponent.find('.download-callout-mock').length).to.equal(1);
8686
});
8787

88+
it('should render components based on the rendereach function', () => {
89+
const component: any = dataSet.data.sitecore.route;
90+
const phKey = 'main';
91+
92+
const renderedComponent = mount(
93+
<SitecoreContext componentFactory={componentFactory}>
94+
<Placeholder
95+
name={phKey}
96+
rendering={component}
97+
renderEach={(comp) => <div className="wrapper">{comp}</div>}
98+
/>
99+
</SitecoreContext>
100+
);
101+
102+
expect(renderedComponent.find('.wrapper').length).to.equal(1);
103+
});
104+
105+
it('should render components based on the render function', () => {
106+
const component: any = dataSet.data.sitecore.route;
107+
const phKey = 'main';
108+
109+
const renderedComponent = mount(
110+
<SitecoreContext componentFactory={componentFactory}>
111+
<Placeholder
112+
name={phKey}
113+
rendering={component}
114+
render={(comp) => <div className="wrapper">{comp}</div>}
115+
/>
116+
</SitecoreContext>
117+
);
118+
119+
expect(renderedComponent.find('.wrapper').length).to.equal(1);
120+
});
121+
122+
it('when null passed to render function', () => {
123+
it('should render empty placeholder', () => {
124+
const component: any = dataSet.data.sitecore.route;
125+
const phKey = 'main';
126+
127+
const renderedComponent = mount(
128+
<SitecoreContext componentFactory={componentFactory}>
129+
<Placeholder
130+
name={phKey}
131+
rendering={component}
132+
render={() => null}
133+
/>
134+
</SitecoreContext>
135+
);
136+
137+
const placeholder = renderedComponent.find(Placeholder)
138+
expect(placeholder.length).to.equal(1);
139+
expect(placeholder.children()).to.be.empty;
140+
});
141+
})
142+
143+
it('should render output based on the renderEmpty function in case of no renderings', () => {
144+
let component: any = dataSet.data.sitecore.route;
145+
const renderings = component.placeholders.main.filter(({ componentName }: any) => !componentName);
146+
const myComponent = {
147+
...component,
148+
placeholders: {
149+
...component.placeholders,
150+
main: [...renderings],
151+
},
152+
};
153+
154+
const phKey = 'main';
155+
156+
const renderedComponent = mount(
157+
<SitecoreContext componentFactory={componentFactory}>
158+
<Placeholder
159+
name={phKey}
160+
rendering={myComponent}
161+
renderEmpty={(comp) => <div className="wrapper">{comp}</div>}
162+
/>
163+
</SitecoreContext>
164+
);
165+
166+
expect(renderedComponent.find('.wrapper').length).to.equal(1);
167+
expect(renderedComponent.find('.download-callout-mock').length).to.equal(0);
168+
expect(renderedComponent.find('.home-mock').length).to.equal(0);
169+
expect(renderedComponent.find('.jumbotron-mock').length).to.equal(0);
170+
});
171+
88172
it('should pass properties to nested components', () => {
89173
const component = dataSet.data.sitecore.route as any;
90174
const phKey = 'main';

0 commit comments

Comments
 (0)