Skip to content

Commit 69f9011

Browse files
#559044: fixed rendering dynamic placeholder
1 parent 8b8d227 commit 69f9011

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

packages/sitecore-jss-react/src/components/PlaceholderCommon.tsx

+7-6
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ import {
1212
import { convertAttributesToReactProps } from '../utils';
1313
import { HiddenRendering, HIDDEN_RENDERING_NAME } from './HiddenRendering';
1414

15-
/** [SXA] common marker by which we find container fo replacing **/
16-
const PREFIX_PLACEHOLDER = 'container-{*}';
17-
1815
type ErrorComponentProps = {
1916
[prop: string]: unknown;
2017
};
@@ -122,9 +119,13 @@ export class PlaceholderCommon<T extends PlaceholderProps> extends React.Compone
122119
let result;
123120
/** [SXA] it needs for deleting dynamics placeholder when we set him number(props.name) of container.
124121
from backend side we get common name of placeholder is called 'container-{*}' where '{*}' marker for replacing **/
125-
if (rendering && rendering.placeholders && rendering.placeholders[PREFIX_PLACEHOLDER]) {
126-
rendering.placeholders[name] = rendering.placeholders[PREFIX_PLACEHOLDER];
127-
delete rendering.placeholders[PREFIX_PLACEHOLDER];
122+
if (rendering && rendering.placeholders) {
123+
Object.keys(rendering.placeholders).forEach((placeholder) => {
124+
if (placeholder.indexOf('{*}') !== -1) {
125+
rendering.placeholders[name] = rendering.placeholders[placeholder];
126+
delete rendering.placeholders[placeholder];
127+
}
128+
});
128129
}
129130

130131
if (rendering && rendering.placeholders && Object.keys(rendering.placeholders).length > 0) {

0 commit comments

Comments
 (0)