Skip to content

Commit f4f5c58

Browse files
illiakovalenkoilliakovalenko
authored
[BYOC] Form's submission is failing. Updated @sitecore-feaas/clientside to v0.5.19. Updated @sitecore-cloudsdk to v0.4.1. (#1966)
* [BYOC] Updated @sitecore-feaas/clientside to v0.5.19, passed rendering data to FEAAS.ExternalComponent * Updated CloudSDK to 0.4.1 * Updated CHANGELOG * Updated CHANGELOG * Updated yarn.lock * Updated @sitecore/components to ~2.0.1-alpha.1
1 parent 41544c7 commit f4f5c58

File tree

9 files changed

+70
-55
lines changed

9 files changed

+70
-55
lines changed

‎CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,11 @@ Our versioning strategy is as follows:
9191
* `[templates/angular]``[templates/node-xmcloud-proxy]``[templates/node-headless-ssr-proxy]``[templates/node-headless-ssr-experience-edge]` Adjust out of box .gitignore rules
9292
* New Angular add-on's are not scaffolded within build pipeline ([#1962](https://github.com/Sitecore/jss/pull/1962))
9393

94+
## 22.2.1
95+
96+
### 🐛 Bug Fixes
97+
* [BYOC] Form's submission is failing. Updated @sitecore-feaas/clientside to v0.5.19. Passed rendering data to FEAAS.ExternalComponent. Updated @sitecore-cloudsdk to v0.4.1. ([#1966](https://github.com/Sitecore/jss/pull/1966))
98+
9499
## 22.2.0
95100

96101
### 🛠 Breaking Change

‎packages/create-sitecore-jss/src/templates/angular-xmcloud/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
"prepare:proxy-build": "ts-node --project src/tsconfig.webpack-server.json ./scripts/proxy-build.ts"
99
},
1010
"dependencies": {
11-
"@sitecore-cloudsdk/core": "^0.4.0",
12-
"@sitecore-cloudsdk/events": "^0.4.0",
11+
"@sitecore-cloudsdk/core": "^0.4.1",
12+
"@sitecore-cloudsdk/events": "^0.4.1",
1313
"font-awesome": "^4.7.0",
1414
"sass": "^1.52.3",
1515
"sass-alias": "^1.0.5"

‎packages/create-sitecore-jss/src/templates/nextjs-xmcloud/package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{
22
"dependencies": {
3-
"@sitecore/components": "~2.0.0",
4-
"@sitecore-cloudsdk/core": "^0.4.0",
5-
"@sitecore-cloudsdk/events": "^0.4.0",
6-
"@sitecore-feaas/clientside": "^0.5.17"
3+
"@sitecore/components": "~2.0.1-alpha.1",
4+
"@sitecore-cloudsdk/core": "^0.4.1",
5+
"@sitecore-cloudsdk/events": "^0.4.1",
6+
"@sitecore-feaas/clientside": "^0.5.19"
77
}
88
}

‎packages/sitecore-jss-nextjs/package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
"url": "https://github.com/sitecore/jss/issues"
3030
},
3131
"devDependencies": {
32-
"@sitecore-cloudsdk/core": "^0.4.0",
33-
"@sitecore-cloudsdk/personalize": "^0.4.0",
32+
"@sitecore-cloudsdk/core": "^0.4.1",
33+
"@sitecore-cloudsdk/personalize": "^0.4.1",
3434
"@types/chai": "^4.3.4",
3535
"@types/chai-as-promised": "^7.1.5",
3636
"@types/chai-string": "^1.4.2",
@@ -66,8 +66,8 @@
6666
"typescript": "~4.9.4"
6767
},
6868
"peerDependencies": {
69-
"@sitecore-cloudsdk/core": "^0.4.0",
70-
"@sitecore-cloudsdk/personalize": "^0.4.0",
69+
"@sitecore-cloudsdk/core": "^0.4.1",
70+
"@sitecore-cloudsdk/personalize": "^0.4.1",
7171
"next": "^14.2.7",
7272
"react": "^18.2.0",
7373
"react-dom": "^18.2.0"

‎packages/sitecore-jss-proxy/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
"url": "https://github.com/sitecore/jss/issues"
2828
},
2929
"dependencies": {
30-
"@sitecore-cloudsdk/core": "^0.4.0",
31-
"@sitecore-cloudsdk/personalize": "^0.4.0",
30+
"@sitecore-cloudsdk/core": "^0.4.1",
31+
"@sitecore-cloudsdk/personalize": "^0.4.1",
3232
"@sitecore-jss/sitecore-jss": "22.3.0-canary.4",
3333
"http-proxy-middleware": "^2.0.6",
3434
"http-status-codes": "^2.2.0",

‎packages/sitecore-jss-react/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
"url": "https://github.com/sitecore/jss/issues"
2727
},
2828
"devDependencies": {
29-
"@sitecore-feaas/clientside": "^0.5.6",
29+
"@sitecore-feaas/clientside": "^0.5.19",
3030
"@types/chai": "^4.3.4",
3131
"@types/chai-string": "^1.4.2",
3232
"@types/enzyme": "^3.10.12",
@@ -56,7 +56,7 @@
5656
"typescript": "~4.9.3"
5757
},
5858
"peerDependencies": {
59-
"@sitecore-feaas/clientside": "^0.5.6",
59+
"@sitecore-feaas/clientside": "^0.5.19",
6060
"react": "^18.2.0",
6161
"react-dom": "^18.2.0"
6262
},

‎packages/sitecore-jss-react/src/components/BYOCComponent.test.tsx

+5
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ import { MissingComponent, MissingComponentProps } from './MissingComponent';
88
describe('BYOCComponent', () => {
99
it('should render with props when ComponentProps is provided', () => {
1010
const mockProps = {
11+
rendering: {
12+
uid: '1111-2222-3333-4444',
13+
componentName: 'BYOCWrapper',
14+
},
1115
params: {
1216
ComponentName: 'Foo',
1317
ComponentProps: JSON.stringify({ prop1: 'value1' }),
@@ -29,6 +33,7 @@ describe('BYOCComponent', () => {
2933
expect(fooComponent.prop('prop1')).to.equal('value1');
3034
expect(fooComponent.prop('data-external-id')).to.equal('Foo');
3135
expect(fooComponent.find('#foo-content')).to.have.length(1);
36+
expect(fooComponent.prop('uid')).to.equal('1111-2222-3333-4444');
3237
});
3338

3439
it('should use datasource fields when provided', () => {

‎packages/sitecore-jss-react/src/components/BYOCComponent.tsx

+7-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from 'react';
2-
import { ComponentFields } from '@sitecore-jss/sitecore-jss/layout';
2+
import { ComponentFields, ComponentRendering } from '@sitecore-jss/sitecore-jss/layout';
33
import { getDataFromFields } from '../utils';
44
import { MissingComponent, MissingComponentProps } from './MissingComponent';
55
import * as FEAAS from '@sitecore-feaas/clientside/react';
@@ -43,6 +43,10 @@ export type BYOCComponentParams = {
4343
* Props for BYOCComponent. Includes components list to load external components from.
4444
*/
4545
export type BYOCComponentClientProps = {
46+
/**
47+
* rendering data
48+
*/
49+
rendering: ComponentRendering;
4650
/**
4751
* rendering params
4852
*/
@@ -157,6 +161,7 @@ export class BYOCComponent extends React.Component<BYOCComponentProps> {
157161
// we render fallback on client to avoid problems with client-only components
158162
return (
159163
<FEAAS.ExternalComponent
164+
{...props.rendering}
160165
componentName={componentName}
161166
clientFallback={fallbackComponent}
162167
datasources={dataSourcesData}
@@ -172,7 +177,7 @@ export class BYOCComponent extends React.Component<BYOCComponentProps> {
172177
*/
173178
export async function fetchBYOCComponentServerProps(
174179
params: BYOCComponentParams
175-
): Promise<BYOCComponentProps> {
180+
): Promise<BYOCServerProps> {
176181
const fetchDataOptions: FEAAS.DataOptions = params.ComponentDataOverride
177182
? JSON.parse(params.ComponentDataOverride)
178183
: {};

‎yarn.lock

+39-39
Original file line numberDiff line numberDiff line change
@@ -5997,52 +5997,52 @@ __metadata:
59975997
languageName: node
59985998
linkType: hard
59995999

6000-
"@sitecore-cloudsdk/core@npm:^0.4.0":
6001-
version: 0.4.0
6002-
resolution: "@sitecore-cloudsdk/core@npm:0.4.0"
6000+
"@sitecore-cloudsdk/core@npm:^0.4.1":
6001+
version: 0.4.1
6002+
resolution: "@sitecore-cloudsdk/core@npm:0.4.1"
60036003
dependencies:
6004-
"@sitecore-cloudsdk/utils": ^0.4.0
6004+
"@sitecore-cloudsdk/utils": ^0.4.1
60056005
debug: ^4.3.4
6006-
checksum: 0640147f4767c6d84f90bbefe011fcc76d2fb47adc078f5017f7c2d686c7eff53a661cd77c4b70315c06b2be0b071c8d279a0db3502bcf5e6e288d1a36dd8896
6006+
checksum: c64d45229f90b393fb423972af4fccb455fb6e5a3dd326eb65b42c6690cc5a535672fffa674c58736a530c2c6c77f0e3faf27a69b6fd2832aafbb04d895db151
60076007
languageName: node
60086008
linkType: hard
60096009

6010-
"@sitecore-cloudsdk/events@npm:^0.4.0":
6011-
version: 0.4.0
6012-
resolution: "@sitecore-cloudsdk/events@npm:0.4.0"
6010+
"@sitecore-cloudsdk/events@npm:^0.4.1":
6011+
version: 0.4.1
6012+
resolution: "@sitecore-cloudsdk/events@npm:0.4.1"
60136013
dependencies:
6014-
"@sitecore-cloudsdk/core": ^0.4.0
6015-
"@sitecore-cloudsdk/utils": ^0.4.0
6016-
checksum: 0e36c44b4bfd23e71b46f20d9ef852e8a948da3ff9f037e37b8a68f4c36220f48d44c2a032979855a5945ed0b100272f7a477ea1f7fdc6b77eab4a32a1d22657
6014+
"@sitecore-cloudsdk/core": ^0.4.1
6015+
"@sitecore-cloudsdk/utils": ^0.4.1
6016+
checksum: 8b4727473bc6dbe0ac70e4c0050e78634303262e3d6d088f1e1225c18835431c1c930921601403074435d4a42ffbcb61bcc06cb0e85210a273c5ebc2025232a4
60176017
languageName: node
60186018
linkType: hard
60196019

6020-
"@sitecore-cloudsdk/personalize@npm:^0.4.0":
6021-
version: 0.4.0
6022-
resolution: "@sitecore-cloudsdk/personalize@npm:0.4.0"
6020+
"@sitecore-cloudsdk/personalize@npm:^0.4.1":
6021+
version: 0.4.1
6022+
resolution: "@sitecore-cloudsdk/personalize@npm:0.4.1"
60236023
dependencies:
6024-
"@sitecore-cloudsdk/core": ^0.4.0
6025-
"@sitecore-cloudsdk/events": ^0.4.0
6026-
"@sitecore-cloudsdk/utils": ^0.4.0
6027-
checksum: 62668f95a111c1b25668c20fc7cf0bf1958b3aefaf2b9c6cdb79179de4e508b7b466e25654f8efcaefdbffd86a715f210e76f2fda964650f601b0fc9e0579893
6024+
"@sitecore-cloudsdk/core": ^0.4.1
6025+
"@sitecore-cloudsdk/events": ^0.4.1
6026+
"@sitecore-cloudsdk/utils": ^0.4.1
6027+
checksum: 2a13fe671aa0319a5e845a15cbf96adbc77a9269b6e18ceb2d813ff5ef88cb0d95332d68db83507d01712e8a19afdddc01fb9a995b508fdd3f0c7dfd49b3e754
60286028
languageName: node
60296029
linkType: hard
60306030

6031-
"@sitecore-cloudsdk/utils@npm:^0.4.0":
6032-
version: 0.4.0
6033-
resolution: "@sitecore-cloudsdk/utils@npm:0.4.0"
6034-
checksum: ec5a0611ad4d6ae4b3c2a7542c2021f0b956d2c78e08cab1ff8bd5e6300c3059d5fff6022d0ed2462cd0b4f127d02b5bfabf34e890cddbb51876aebaca3033dc
6031+
"@sitecore-cloudsdk/utils@npm:^0.4.1":
6032+
version: 0.4.1
6033+
resolution: "@sitecore-cloudsdk/utils@npm:0.4.1"
6034+
checksum: 719657350cb6871b28c1b88cc3666496d7cc42d5b85eb503441b79e164b40d80ad22d1bea6330bd415b31c00ac7c0a3c24033ec064caff0637b5621efe820205
60356035
languageName: node
60366036
linkType: hard
60376037

6038-
"@sitecore-feaas/clientside@npm:^0.5.6":
6039-
version: 0.5.9
6040-
resolution: "@sitecore-feaas/clientside@npm:0.5.9"
6038+
"@sitecore-feaas/clientside@npm:^0.5.19":
6039+
version: 0.5.19
6040+
resolution: "@sitecore-feaas/clientside@npm:0.5.19"
60416041
dependencies:
6042-
"@sitecore/byoc": ^0.2.8
6042+
"@sitecore/byoc": ^0.2.10
60436043
peerDependencies:
60446044
react-dom: ">=16.8.0"
6045-
checksum: ae5a3c57b104f7ce849341b3b01204210e4f6060f751567aee32a21df77e127bacba970bce2f3eb4f0a4959351f112791d6c7027eb210300e8476defef790115
6045+
checksum: 63bcc151e9d79cc591c98f2f68cae8feb9b6a368ba9b4f12aa74a418a208e20cd37d682e671bb7a32ed275a78e7dca3034678af5943961afa2b2ce4d8ddc2955
60466046
languageName: node
60476047
linkType: hard
60486048

@@ -6224,8 +6224,8 @@ __metadata:
62246224
version: 0.0.0-use.local
62256225
resolution: "@sitecore-jss/sitecore-jss-nextjs@workspace:packages/sitecore-jss-nextjs"
62266226
dependencies:
6227-
"@sitecore-cloudsdk/core": ^0.4.0
6228-
"@sitecore-cloudsdk/personalize": ^0.4.0
6227+
"@sitecore-cloudsdk/core": ^0.4.1
6228+
"@sitecore-cloudsdk/personalize": ^0.4.1
62296229
"@sitecore-jss/sitecore-jss": 22.3.0-canary.4
62306230
"@sitecore-jss/sitecore-jss-dev-tools": 22.3.0-canary.4
62316231
"@sitecore-jss/sitecore-jss-react": 22.3.0-canary.4
@@ -6267,8 +6267,8 @@ __metadata:
62676267
ts-node: ^10.9.1
62686268
typescript: ~4.9.4
62696269
peerDependencies:
6270-
"@sitecore-cloudsdk/core": ^0.4.0
6271-
"@sitecore-cloudsdk/personalize": ^0.4.0
6270+
"@sitecore-cloudsdk/core": ^0.4.1
6271+
"@sitecore-cloudsdk/personalize": ^0.4.1
62726272
next: ^14.2.7
62736273
react: ^18.2.0
62746274
react-dom: ^18.2.0
@@ -6279,8 +6279,8 @@ __metadata:
62796279
version: 0.0.0-use.local
62806280
resolution: "@sitecore-jss/sitecore-jss-proxy@workspace:packages/sitecore-jss-proxy"
62816281
dependencies:
6282-
"@sitecore-cloudsdk/core": ^0.4.0
6283-
"@sitecore-cloudsdk/personalize": ^0.4.0
6282+
"@sitecore-cloudsdk/core": ^0.4.1
6283+
"@sitecore-cloudsdk/personalize": ^0.4.1
62846284
"@sitecore-jss/sitecore-jss": 22.3.0-canary.4
62856285
"@types/chai": ^4.3.4
62866286
"@types/express": ^4.17.17
@@ -6387,7 +6387,7 @@ __metadata:
63876387
version: 0.0.0-use.local
63886388
resolution: "@sitecore-jss/sitecore-jss-react@workspace:packages/sitecore-jss-react"
63896389
dependencies:
6390-
"@sitecore-feaas/clientside": ^0.5.6
6390+
"@sitecore-feaas/clientside": ^0.5.19
63916391
"@sitecore-jss/sitecore-jss": 22.3.0-canary.4
63926392
"@types/chai": ^4.3.4
63936393
"@types/chai-string": ^1.4.2
@@ -6420,7 +6420,7 @@ __metadata:
64206420
ts-node: ^10.9.1
64216421
typescript: ~4.9.3
64226422
peerDependencies:
6423-
"@sitecore-feaas/clientside": ^0.5.6
6423+
"@sitecore-feaas/clientside": ^0.5.19
64246424
react: ^18.2.0
64256425
react-dom: ^18.2.0
64266426
languageName: unknown
@@ -6520,13 +6520,13 @@ __metadata:
65206520
languageName: unknown
65216521
linkType: soft
65226522

6523-
"@sitecore/byoc@npm:^0.2.8":
6524-
version: 0.2.8
6525-
resolution: "@sitecore/byoc@npm:0.2.8"
6523+
"@sitecore/byoc@npm:^0.2.10":
6524+
version: 0.2.15
6525+
resolution: "@sitecore/byoc@npm:0.2.15"
65266526
dependencies:
65276527
"@rjsf/utils": "*"
65286528
json-schema: ^0.4.0
6529-
checksum: fb5545021a4e78b05b20d03eb38a663a6bf8453679e0a3fa4ae4477989571c7ce4ece304e4d27c3f1a119d3b2ac20045da9e6eff743c814cebd882b10635642d
6529+
checksum: 5da0cd994a55e0809433d0534c1ffcf39a306a8e3769d5aecfc95113c7a2f69ada7c27db9e1bb1ac40bc5a7bbf50344689f1096811bdc8c291067044bafd7dbe
65306530
languageName: node
65316531
linkType: hard
65326532

0 commit comments

Comments
 (0)