Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI deploy options do not trigger build step (Vue sample app) #336

Closed
kbauer-hhog opened this issue Feb 28, 2020 · 2 comments
Closed

CLI deploy options do not trigger build step (Vue sample app) #336

kbauer-hhog opened this issue Feb 28, 2020 · 2 comments
Assignees

Comments

@kbauer-hhog
Copy link
Contributor

kbauer-hhog commented Feb 28, 2020

Description

Build step is not being run before jss deploy app or jss deploy files CLI commands.

I had to manually build using jss build, and then running jss deploy files.

This was found using the Vue sample app. Unsure if other sample apps are having this issue.

Expected behavior

I expect the build step to be run by default.
Documentation and --help say that option --skipBuild is false by default.

Steps To Reproduce

  1. Run jss deploy app or jss deploy files via command line.
  2. Build step will not run. It will only attempt to copy the ./dist/ folder to the instance.

Possible Fix

A debug of argv.skipBuild variable in @sitecore-jss/sitecore-jss-cli/dist/scripts/deploy.files.js on the latest CLI version shows "false" as a string. The same debug of this same line in version 11.0.2 shows the value as false as a Boolean.

The conditional around the build step is expecting argv.skipBuild to be a Boolean value. This is why it does not build by default.

Your Environment

  • Sitecore Version: 9.3
  • JSS Version: 13.0.3
@kbauer-hhog
Copy link
Contributor Author

Possibly related: #308

@sc-illiakovalenko sc-illiakovalenko self-assigned this Mar 13, 2020
@kbauer-hhog kbauer-hhog changed the title CLI deploy options do not trigger build step CLI deploy options do not trigger build step (Vue sample app) Mar 13, 2020
@sc-illiakovalenko
Copy link
Contributor

Fixed In #345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants