Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jss setup does not work with Sitecore Docker #341

Closed
peternazarov opened this issue Mar 10, 2020 · 2 comments
Closed

jss setup does not work with Sitecore Docker #341

peternazarov opened this issue Mar 10, 2020 · 2 comments
Assignees

Comments

@peternazarov
Copy link

peternazarov commented Mar 10, 2020

Description

Docker deployment directory does not suppose to contain web.config or any other standard Sitecore files. Reference: https://github.com/Sitecore/docker-images

Expected behavior

Docker deployment directory should be accepted without making a check for the default Sitecore files in that directory.

Steps To Reproduce

run jss setup and use Sitecore Docker deployment directory.

Possible Fix

Remove Sitecore files check in the deployment directory.

Your Environment

latest as of today. others are N/A.

Screenshots

image

jss setup
Is your Sitecore instance on this machine or accessible via network share? [y/n]: y
Path to the Sitecore folder (e.g. c:\inetpub\wwwroot\my.siteco.re): C:\Projects\SitecoreHelixSolutionTemplateTest2\docker\deploy
C:\Projects\SitecoreHelixSolutionTemplateTest2\docker\deploy did not look like a valid Sitecore website or headless proxy (missing 'sitecore' folder, Web.config, or package.json)!```
@sshushliapin
Copy link

Faced the same issue. Creating empty sitecore directory did the trick (as mentioned in the error message).

But, I do agree with you that this check looks awkward in case of Docker environment. My vote is for getting rid of it.

@sc-illiakovalenko
Copy link
Contributor

Fixed in #361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants