Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent the Angular scLink directive from adding an href attribute, when href is equal to http:// or https:// #408

Closed
sc-illiakovalenko opened this issue Jul 15, 2020 · 2 comments
Closed

Prevent the Angular scLink directive from adding an href attribute, when href is equal to http:// or https:// #408

sc-illiakovalenko opened this issue Jul 15, 2020 · 2 comments
Assignees
@sc-illiakovalenko

Comments

@sc-illiakovalenko
Copy link
Contributor

Related to #380. Need to extend #406 in order to prevent adding of href attribute when href is equal to http:// or https://
@sc-illiakovalenko sc-illiakovalenko self-assigned this Jul 15, 2020
This was referenced Jul 15, 2020
Closed
Merged
@sc-illiakovalenko
Copy link
Contributor Author

Fixed in #409
@callmeaponte As I promised 😉

@callmeaponte
Copy link
Contributor

@sc-illiakovalenko thank you! It's much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sc-illiakovalenko sc-illiakovalenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@callmeaponte @sc-illiakovalenko