Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strong types for fram::Address and fram::Size #308

Closed
Tracked by #257
PatrickKa opened this issue Jul 6, 2024 · 2 comments · Fixed by #312
Closed
Tracked by #257

Add strong types for fram::Address and fram::Size #308

PatrickKa opened this issue Jul 6, 2024 · 2 comments · Fixed by #312

Comments

@PatrickKa
Copy link
Contributor

PatrickKa commented Jul 6, 2024

Description

Use the new strong_type library instead of NamedType. It should look something like

#include <strong_type/strong_type.hpp>

using Size = strong::type<std::uint32_t, struct SizeTag, probably_some_modifiers>;
using Address = strong::type<std::uint32_t, struct AddressTag, strong::affine_point<Size>, probably_more_modifiers>;

Regarding the potential modifiers, I would assume that something like strong::equality, strong::ordered, or strong::strongly_ordered could be necessary.

@PatrickKa
Copy link
Contributor Author

Blocked because while SpaceTeam/STS1_COBC_Docker#58 is already implemented, a new version of the Docker image is not yet released.

@PatrickKa
Copy link
Contributor Author

Until the new version of the Docker image is released, we installed the library locally in our container to not be blocked by that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants