Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firework effects of a firework rocket are not synchronized with client #4116

Closed
pandier opened this issue Aug 3, 2024 · 0 comments · Fixed by #4117
Closed

Firework effects of a firework rocket are not synchronized with client #4116

pandier opened this issue Aug 3, 2024 · 0 comments · Fixed by #4117
Labels
status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage type: bug Something isn't working

Comments

@pandier
Copy link
Contributor

pandier commented Aug 3, 2024

Affected Product(s)

SpongeVanilla

Version

1.20.6-11.0.1-RC1778

Operating System

Linux (Fedora 40)

Java Version

openjdk 21.0.3

Plugins/Mods

- Custom plugin (called 'lightshow')

Describe the bug

Whenever FIREWORK_EFFECTS is modified on a firework rocket entity, the data is not synchronized with the client. Modified data can bee seen using the /data command, but the client doesn't show any firework effects.

Reproducing

When using registering the following command:

final Command.Parameterized fireworkCommand = Command.builder()
                .executor(context -> {
                    final ServerPlayer player = context.cause().first(ServerPlayer.class).orElseThrow();
                    final ServerWorld world = player.world();
                    final FireworkRocket rocket = world.createEntity(EntityTypes.FIREWORK_ROCKET, player.position());
                    rocket.offer(Keys.FIREWORK_EFFECTS, List.of(FireworkEffect.builder().color(Color.RED).shape(FireworkShapes.BURST).build()));
                    rocket.offer(Keys.FIREWORK_FLIGHT_MODIFIER, Ticks.of(1));
                    world.spawnEntity(rocket);
                    return CommandResult.success();
                })
                .build()

and then executing the command as a player, the rocket is spawned and flies for a bit, but when it should explode with the specified firework effects, it just disappears instead.

Link to logs

https://paste.gg/p/anonymous/af2f41e0bfec4802904a23312cbcc07d

@pandier pandier added status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage type: bug Something isn't working labels Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant