New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NewSeason returns empty episode list and no error #16

Open

StalkR opened this issue Jan 13, 2025 · 1 comment

Labels

bug

Owner

StalkR commented Jan 13, 2025

Hey @windblows95,

I just noticed the tests for Season/Episodes from your PR #14 are failing: returning empty season/episode.

The call to NewSeason returns without error but the episode list is empty: https://github.com/StalkR/imdb/blob/master/season_test.go#L174

Test log: https://github.com/StalkR/imdb/actions/runs/12748036337/job/35527355036

If possible, it should catch something went wrong with parsing and return an error (e.g. could not parse).
And then, if you can fix the parsing so it returns the episode list.

Filing this in case you're willing to look into it.

The text was updated successfully, but these errors were encountered:

StalkR added the bug label

windblows95 mentioned this issue

season: new information retrieval strategy #17

Closed

Contributor

windblows95 commented Jan 19, 2025

Addressed in my latest PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment