Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby 3.4 error #273

Closed
igorkasyanchuk opened this issue Dec 29, 2024 · 1 comment · Fixed by #275
Closed

Ruby 3.4 error #273

igorkasyanchuk opened this issue Dec 29, 2024 · 1 comment · Fixed by #275

Comments

@igorkasyanchuk
Copy link

Hello, have an error
image

The same code works fine with Ruby 3.3.6. No issues. PDF is simple, nothing special.

If I debug I see the following in "result" variable

image
@murajun1978 murajun1978 mentioned this issue Dec 30, 2024
Merged
@abrom
Copy link
Contributor

abrom commented Jan 13, 2025

Not sure why this was tagged to the Ruby 3.4 PR?

The issue would appear to be your use of a 4 1/2 year old version of the gem, presumably with puppeteer v23.x+ which are definitely incompatible.

#258 fixes this (released in v1.1.10)

You'd either need to revert to puppeteer < v23.x or update Grover to v1.1.10+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Ruby 3.4 support murajun1978/grover
2 participants
@igorkasyanchuk @abrom