Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect main branch #6

Open
ekuiter opened this issue Mar 6, 2025 · 0 comments
Open

Protect main branch #6

ekuiter opened this issue Mar 6, 2025 · 0 comments

Comments

@ekuiter
Copy link
Member

ekuiter commented Mar 6, 2025

There's a lot of rules we can set here.

For now, I created a ruleset that heavily restricts how we can interact with the main branch, with the following rules:

  • pushes to main are not allowed (enforcing the use of branches)
  • force pushes to main are not allowed (this is a separate rule to the first one)
  • no linear history is required (so merges, squashes, and rebases are all allowed, I don't think we need to restrict that)
  • we do not require signed commits (it's overkill)
  • merges are only possible when there is an associated pull request
    • this pull request needs to have least one approving review before allowing the merge
    • you cannot review your own pull request
    • all comments must be resolved before allowing the merge
    • if new changes are added to a pull request, a re-review is not necessary (these are options that are not documented very well and have many edge cases)
  • CI is required to pass before allowing the merge

We can discuss here (or just try out for a while) whether that is too restrictive, I set the rules subjectively. We can also set specific people who can bypass these restrictions, if necessary.

@ekuiter ekuiter changed the title protect main branch https://github.com/TUBS-ISF/BibTags/settings/rules Protect main branch Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant