Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] improve theme options in the appearance section #1034

Closed
ghost opened this issue Jan 27, 2018 · 7 comments
Closed

[Feature Request] improve theme options in the appearance section #1034

ghost opened this issue Jan 27, 2018 · 7 comments
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@ghost
Copy link

ghost commented Jan 27, 2018

• [x] I carefully read the contribution guidelines and agree to them.
• [x] I checked if the issue/feature exists in the latest version.

they could add a palette of colors to change the red color that comes by default in the application

ps: the image is a capture of the appearance settings of the KISS launcher

@theScrabi
Copy link
Member

The idea is that every service gets its own color. So when you select soundcloud then the app gets orange.

@ghost
Copy link
Author

ghost commented Jan 27, 2018

I had already read about that, but even so it would not be bad to add that option to the one who anyway wants to use a predetermined color in the application. or they could even add what colors each service must have, it would make newpipe even more customizable :)

@ghost
Copy link
Author

ghost commented Jan 27, 2018

It's just a suggestion, I'm just complicating things 😂

@theScrabi
Copy link
Member

We could keep it in mind. If soemone is sending a PR allowing that I would not hold it back.

@ghost
Copy link
Author

ghost commented Jan 27, 2018

maybe it does not have much to do with this, 👀 but I came up with this idea while using the k9-mail application because the settings can be assigned a different color for each email you use. I thought you can do something similar here, assign a custom color for each newpipe service (youtube, soundcloud, twitch, vimeo)

@stale

This comment has been minimized.

@stale stale bot added the stale label Dec 1, 2018
@Stypox Stypox added the feature request Issue is related to a feature in the app label Jun 23, 2019
@Stypox Stypox added the GUI Issue is related to the graphical user interface label Jul 18, 2019
@TobiGr TobiGr removed the stale label Jul 19, 2019
@litetex
Copy link
Member

litetex commented Oct 20, 2021

The idea is that every service gets its own color. So when you select soundcloud then the app gets orange.

This got implemented a few versions ago.

We also have now 3 appearance options: light, dark and night.

Also the link in the description dead.

Closing the issue, as everything was more or less implemented and the issue has 0 upvotes since >3 years.

@litetex litetex closed this as completed Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

4 participants