Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play video in details page (as popup) #1200

Closed
Rubylion opened this issue Mar 23, 2018 · 6 comments
Closed

Play video in details page (as popup) #1200

Rubylion opened this issue Mar 23, 2018 · 6 comments
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@Rubylion
Copy link

Hi. Would it be possible to make the video play in the resultpage.
Meaning, when you click a video in the list, the next page opens, where the video is on top and other sruff,incl. suggestions are displayed.
I would like to playback the video in that top window, instead of going to fullscreen imediatley. Therefore i can read the notes and browse the suggestions while watching the playback.
Very beautiful app by the way. Thanx

@theScrabi
Copy link
Member

@avently is currently working on this #834

@Rubylion
Copy link
Author

great

@stale
Copy link

stale bot commented Dec 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2018
@Stypox Stypox added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Jul 19, 2019
@TobiGr TobiGr removed the stale label Jul 19, 2019
@Stypox Stypox changed the title [feature request]video playback in results Play video in details page (as popup) Aug 29, 2019
@opusforlife2
Copy link
Collaborator

@theScrabi I think it would be far simpler if there is a toggle in app settings so a popup can automatically play in the video details page for those users who want it (should it be the default option?). This will require some small changes in the mechanics of the popup:

  • The default position and size of the popup is changed so that it occupies the full screen width and is placed over where the thumbnail should normally be.
  • Swiping down on this auto popup could shrink and place it at the bottom right just like in the official app. From there, it can be moved around or resized as needed. The closing method stays the same.

This can emulate the convenience of the official app, without causing the complications that came with the PR you linked to.

@Stypox This is an alternative for the instant playback solution I proposed here. #2583 (comment)

@Stypox
Copy link
Member

Stypox commented Jan 10, 2020

Fixed by #2907

@opusforlife2
Copy link
Collaborator

Done.

@wb9688 wb9688 closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

6 participants