Use same icon logic for main and pop-up players

[rancidfrog]

Checklist

•  I checked, but didn't find any duplicates of this issue in the repo.

•  I have read the contribution guidelines given at https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md.

•  This issue contains only one feature request. I will open one issue for every feature I want to request.

Describe the feature you want

Took me a while to find share button. But, it works well. The arrow icon with the share below, that is.

Only issue is why this is not also used in pop-up player?
Full video player

vs
Pop-Up

Is it not possible to have the same implementation in both?
It should be logical that the same design should be continued, so that users will not be confused where to find those buttons

Is your feature request related to a problem? Please describe it

There is no share button in pop-up player.
User needs to click on Full player icon (So, there is space for an icon🤔🤨)
Then click on arrow icon, then click on share.
App does not use same logic and implementation for similar issue.
The space required is the same for an arrow button and a full screen button, so that should not be a problem.
If there is not enough space, just do not show it, same as other icons already bein displayed - Resolution, Speed, Full screen

The only change would be for the full screen button to be under the umbrella of the arrow key on the right, along with share button ...

Having the arrow key beside the full screen icon should not be a problem, either:
Full player icons:

Pop-up player icons:

How will you/everyone benefit from this feature?

Users will be able to directly share a video from pop-up player.
App will use same design and logic for screen icons/buttons so no confusion across different players

[rancidfrog]

Replacing full-screen icon with arrow icon, and on click expand with options, all will be able to fit

You see - if you replace full player mode with arrow icon then you can have the same expanding list with share|full screen| etc.

And, this is the smallest pop-up player can go.
So, full-screen will need to be replaced with arrow icon which expands with list of options.

This might be a slight design change in regards to the implementation, but it is the same logic.
Since same arrow key will be used, just space issues forces list view

This change does not make it any more or any less minimalistic. It just gives users more available options when using pop-up player without forcing them to go through full screen mode.
Exactly same level of complexity as now

[rancidfrog]

Thank you @B0pol for interactions, as discussion helps see all solutions to users use-cases

[aladar42]

The pop up player alsp doesnt respect other applications drawing over the screen - e.g. while using Dimmer to tweak the brightness, the pop up player ignores the settings set by Dimmer completely, and plays at system set brightness instead. This does not happen in other apps (Chromium browsers, Twire, VLC)

[triallax]

@aladar42 I think that behavior is expected if the apps you mentiond play videos in popup mode using the PiP player.

[aladar42]

@aladar42 I think that behavior is expected if the apps you mentiond play videos in popup mode using the PiP player.

I'm not sure I understand why NewPipe behaves differently, though?

[triallax]

NewPipe doesn't use the Android PiP player, but its own custom popup player.

[SameenAhnaf]

@aladar42 If I am not wrong, this issue specifically discusses about icons. Also, won't having brightness and volume gestures create conflicts with changing size and position on popup player?