Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Video not available" thumbnail on unplayable videos needs some changes #5609

Closed
3 tasks done
alienthief opened this issue Feb 16, 2021 · 3 comments · Fixed by #6917
Closed
3 tasks done

The "Video not available" thumbnail on unplayable videos needs some changes #5609

alienthief opened this issue Feb 16, 2021 · 3 comments · Fixed by #6917
Labels
feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface localisation / translation Everything that has to do with translations or Weblate

Comments

@alienthief
Copy link

alienthief commented Feb 16, 2021

Checklist

Describe the feature you want

Video not available message is hardcoded to the thumbnail on unavailable/unplayable videos. It would be great if it's changed to a video unavailable text or [better] other text based message that explains why the video is unavailable/playable which follows app language instead of using this [English] thumbnail on every video and on every language.

Additional context

Example video: https://m.youtube.com/watch?v=r4JWI4UDOrc

Screenshot:
Screenshot_20210216-202417

How will you/everyone benefit from this feature?

People will better understand what's going on because they will see the message in their language also the text on the thumbnail is a bit out of the border (text is too close to the border and not aligned to the center also part of of the last letter E is "cut").

@alienthief alienthief added the feature request Issue is related to a feature in the app label Feb 16, 2021
@alienthief alienthief changed the title The "Video unavailable" thumbnail on "unavailable" videos needs some changes The "Video not available" thumbnail on "unavailable" videos needs some changes Feb 16, 2021
@alienthief alienthief changed the title The "Video not available" thumbnail on "unavailable" videos needs some changes The "Video not available" thumbnail on unavailable/unplayable videos needs rewording Feb 16, 2021
@alienthief alienthief changed the title The "Video not available" thumbnail on unavailable/unplayable videos needs rewording The "Video not available" thumbnail on unplayable videos needs rewording Feb 16, 2021
@alienthief alienthief changed the title The "Video not available" thumbnail on unplayable videos needs rewording The "Video not available" thumbnail on unplayable videos needs some changes Feb 16, 2021
@TobiGr TobiGr added GUI Issue is related to the graphical user interface localisation / translation Everything that has to do with translations or Weblate good first issue Easy/simple issues perfect for newcomers to get involved in the project labels Feb 16, 2021
@sherlockbeard
Copy link
Contributor

Current dev version show it like this .
photo6264998645430594357

photo6264998645430594358

So, we just need to crop the current image to not show any text?

@TobiGr
Copy link
Contributor

TobiGr commented Mar 26, 2021

Yes. The best solution is to replace it with a vector graphic

@sherlockbeard
Copy link
Contributor

@TobiGr check #5925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app good first issue Easy/simple issues perfect for newcomers to get involved in the project GUI Issue is related to the graphical user interface localisation / translation Everything that has to do with translations or Weblate
Projects
None yet
3 participants