Release 0.21.2

[TobiGr]

Changelogs

App

New

• Added channel details option to long-press menu Add channel details option to long-press menu #5851
• Add functionality to rename Playlist Name from playlist interface Add functionality to rename Playlist Name from playlist interface #5982
• Add queue time Add queue time #6023

Improved

• Allow the user to pause while a video is buffering #5263: Allow the user to pause while a video is buffering #5929
• Improve colors in white theme, migrate to Android DayNight Theme Migrate to Android DayNight Theme, fix Light Theme, minor UI improvements #5927, Fix release build by updating icon reference #5995
• Stream item improvements Stream item improvements #6004

Fixed

• Fixed overlapping fonts Overlapping fonts #5096 #5813
• Fixed crash on tapping anywhere on video after long-pressing 'Popup' button Overlapping fonts #5096 #5813
• Update URLs to HTTPS in READMEs Update URLs to HTTPS in READMEs #5942
• Fixed some random NullPointerExceptions Fix some random NullPointerExceptions #5944
• Fixed crash in history fragment when interacting with header controls and there are no videos in history App Crashes when no videos in last played and user interacts with playlistController fix #5971
• Fixed hidden icon to the left of notification actions in settings Fix hidden icon to the left of notification actions in settings #5935
• Disabled media tunneling on Hi3798MV200 and cvt_mt5886_eu_1g fixing video playback on Formuler and Zephir Android TV devices Disable media tunneling on Hi3798MV200 #5969, Disable media tunneling on cvt_mt5886_eu_1g #6024
• NullPointerException on screen rotation during exit fix NullPointerException on screen rotation during exit fix #5976
• Fix NullPointerException: Attempt to get length of null array in MainActivity Fix NullPointerException: Attempt to get length of null array in MainActivity #5999
• Fix display of channel details when it has no videos Fix display of channel details when it has no videos #5963

Development

• Replace FrameLayout with FragmentContainerView where applicable Replace FrameLayout with FragmentContainerView where applicable #5882
• Clean up unnecessary onCreate in settings fragments Clean up unnecessary onCreate in settings fragments #5879
• Update gradle wrapper Update gradle wrapper #5866
• About package internal revamp About package internal revamp #5881
• Update to ExoPlayer 2.13.2 Update to ExoPlayer 2.13.2 #5856
• Rearrange libraries Rearrange libraries #5867
• Rename related streams to related items Rename related streams to related items #5974
• Migrate rest of AlertDialogs to AppCompat Migrate rest of AlertDialogs to AppCompat #6001

Extractor

New

• Extract metadata for youtube, soundcloud & mediaccc Extract metadata for youtube, soundcloud & mediaccc NewPipeExtractor#306

Improved

• [Bandcamp] Load more featured pages Load more featured pages and fix featured cover arts not loading NewPipeExtractor#589
• [Bandcamp] Added Radio stream segments [Bandcamp] Add Radio stream segments NewPipeExtractor#607

Fixed

• Update URL to HTTPS in README Update URL to HTTPS in README NewPipeExtractor#591
• [Bandcamp] Fixed featured cover arts not loading Load more featured pages and fix featured cover arts not loading NewPipeExtractor#589

Development

• Code improvements Code improvements NewPipeExtractor#578 Reduce number of type conversions NewPipeExtractor#594
• Rename getRelatedStreams to getRelatedItems and change return type Rename getRelatedStreams to getRelatedItems and change return type NewPipeExtractor#597
• Fix a test and ignore rest Fix a test and ignore rest NewPipeExtractor#598, Fix SoundcloudGoPlusTrack NewPipeExtractor#601, Ignore unreliable SoundcloudGoPlusTrack.testRelatedItems NewPipeExtractor#602
• Add body field to Page and use it Add body field to Page and use it NewPipeExtractor#599

APK for testing

NewPipe_v0.21.2_RC2.zip
Please report only new bugs in this thread.

To Do

• Update translations
• Wrong color of volume indicator in player Release NewPipe 0.21.2 (968) #6053 (comment)
• Fix SoundCloud extraction (SoundCloud extraction is broken #6176)

Corresponding PR: #6053

[opusforlife2]

While testing "pause while buffering", I found out that the Play/Pause button vanishes (until the video resumes playing) if you seek by manually tapping on the Seekbar. But it remains if you use the double tap gesture to skip forward or backward.

This also happens in the current release. Is this intentional or a bug?

[opusforlife2]

Moved @AlexN1997's comment from Release PR to this Release Issue

---

I found a bug:

recording_20210410_153334.1.mp4

How to reproduce:
Play a video and adjust the sound

Device: LG G5 Android 8.0
App version: v0.21.2 rc1

[opusforlife2]

When I tap on a thumbnail to begin a stream, the video buffers, and then immediately pauses when it is about to play. I first encountered this in #5459, and thought it was a bug in that PR.

But that PR isn't merged, so it's a bug in this RC.

[TobiGr]

I get a black volume off icon on dark theme, but cannot reprpduce the other volume drawable bug:

[triallax]

@TobiGr I think I found the cause. I believe the bug was introduced by #5927. While all the other volume icons moved to drawable-night were white, the only one whose black version was the one moved to drawable-night was ic_volume_off.xml.

[AudricV]

I found two bugs:

• When rotating your device in a channel which isn't supported by NewPipe, the app crashes with the following error:

Exception

• User Action: ui error
• Request: ACRA report
• Content Country: FR
• Content Language: fr-FR
• App Language: fr_FR
• Service: none
• Version: 0.21.1
• OS: Linux Android 10 - 29

Crash log

java.lang.NullPointerException: Attempt to read from field 'android.widget.TextView org.schabi.newpipe.databinding.FragmentChannelBinding.errorContentNotSupported' on a null object reference
	at org.schabi.newpipe.fragments.list.channel.ChannelFragment.showContentNotSupported(ChannelFragment.java:508)
	at org.schabi.newpipe.fragments.list.channel.ChannelFragment.handleResult(ChannelFragment.java:475)
	at org.schabi.newpipe.fragments.list.channel.ChannelFragment.handleResult(ChannelFragment.java:67)
	at org.schabi.newpipe.fragments.list.BaseListInfoFragment.doInitialLoadLogic(BaseListInfoFragment.java:115)
	at org.schabi.newpipe.fragments.BaseStateFragment.onViewCreated(BaseStateFragment.java:42)
	at org.schabi.newpipe.fragments.list.channel.ChannelFragment.onViewCreated(ChannelFragment.java:125)
	at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:332)
	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1187)
	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1356)
	at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:1434)
	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1497)
	at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:2625)
	at androidx.fragment.app.FragmentManager.dispatchActivityCreated(FragmentManager.java:2577)
	at androidx.fragment.app.FragmentController.dispatchActivityCreated(FragmentController.java:247)
	at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:541)
	at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java:210)
	at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1440)
	at android.app.Activity.performStart(Activity.java:8109)
	at android.app.ActivityThread.handleStartActivity(ActivityThread.java:3806)
	at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:235)
	at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:215)
	at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:187)
	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:105)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2386)
	at android.os.Handler.dispatchMessage(Handler.java:107)
	at android.os.Looper.loop(Looper.java:213)
	at android.app.ActivityThread.main(ActivityThread.java:8178)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:513)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1101)

---

• The message This content is not supported by NewPipe [...] for unsupported channels isn't shown, maybe it's related to the crash above.

[TobiGr]

Second candidate: NewPipe_v0.21.2_RC2.zip

• [Bandcamp] Extract related items
• [Bandcamp] Radio kiosk; navigate between tracks via chapters
• fixed wrong color of volume indicators
• updated translations

[SameenAhnaf]

I found four new bugs.

(1) Channel details is not shown for videos from playlist or subscription feed videos.

Screenshots

(2) Buffering icon is not shown on full screen. However, it is shown on main player

Screenshot

(3) If 'Black' theme is selected, all menus should be black. Dimming the screen behind is enough to differentiate between list of videos and menu.
(4) Icons on always ask share menu should be white for dark or black theme.

Screenshot

Device: Xiaomi Redmi Note 8 Pro ROM: MIUI 12.0.3

[nadiration]

This maybe related to the above comment, when you share a link from another app and the NewPipe share menu (open with actions) appears and you click an option it doesn't show touch highlights it freezes for a moment and proceeds with your chosen action

[TobiGr]

@shekhar12020 Thank you for testing and reporting!

(1) I cannot reproduce this. Can you give me instructions in how to reproduce the bug or upload a screen cast?.

(2) Reproduced. This was most likely caused by #5929. What I have found so far. The loading circle / progress bar is only shown when starting to load the video. Once it has changed the loading state, the loading progress circle is not shown again. No matter which player you use. E.g. start a long video in portrait mode and you'll see the circle. Jump to a position which has not been loaded yet and no circle is shown.
Edit: I was wrong. This behaviour is also present before the buffer PR was merged, e.g. in ef2c76e
Edit 2: This bug is even present in 0.21.0. @Redirion Maybe one of the exoplayer updates went wrong. Do you have time to look at this?

(3) Yes, but this is the behaviour since the black theme was introduced.

(4) Will be fixed by #6151

@nadiration I cannot reproduce this.

[SameenAhnaf]

@TobiGr Thank you so much for your time and efforts.

(1) As you can see, there are problems only in subscription or playlist feed. Sorry for too fast videos. I had to cover within the file size limit.

Screenrecorder-2021-04-24-06-56-02-81.mp4

However, such problems don't persist in channel feed or search results.

Screenrecorder-2021-04-24-06-53-44-753.mp4

(3) If I am not wrong, you were working on theme. It would have been nice if you looked on this ♥️.

Btw, my name is not Shekhar. If required, please copy my name while mentioning 😅.

[triallax]

@SameenAhnaf see #6155. Please keep the discussion related to this problem there from now on.

[TobiGr]

@SameenAhnaf I am sorry for tagging the wrong person. I was a little sleepy last night ;)

(1) I looked for the wrong things in the popup. My fault. This should be fixed, but not in this release as @mhmdanas pointed out already.

(2) is going to be fixed by #6161

[opusforlife2]

@TobiGr How will the branches be handled? The dev branch already contains merged PRs for the next version. The main branch is only supposed to have hotfixes merged to it directly.