Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OAuth support to get subscriptions (YouTube) #8033

Open
5 tasks done
ghost opened this issue Mar 14, 2022 · 6 comments
Open
5 tasks done

Add OAuth support to get subscriptions (YouTube) #8033

ghost opened this issue Mar 14, 2022 · 6 comments
Labels
discussion This needs to be discussed before anything is done feature request Issue is related to a feature in the app niche Only relevant to a very small amount of people

Comments

@ghost
Copy link

ghost commented Mar 14, 2022

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

The app can now use OAuth to import subscriptions. Essentially, when the app detects google play services, it will add an oauth button. When clicked, it will ask for subscriptions yada yada, and it will begin to import them. You can configure the app on start to import subscriptions, and there is a button to do it manually. Here is an ascii flowchart

(Start)-><Check if Google Play Services is installed>-Yes->[Add Menu Button to add OAuth]->(End)
(When OAuth button clicked)->[Request OAuth permissions: Subscriptions]->[Add Subscriptions just like Google Takeout]->(End)
(When OAuth set up was done and the app starts)->[Start importing subscriptions]->(End)

You can check if an api key is null in the code and if it is, just hide the not functional button.

Why do you want this feature?

It is a pain to manually go to Google Takeout, deselect all, select YouTube, only select subscriptions, and wait 30 seconds to get the download, and import it into NewPipe. On a mobile device which makes it 100x harder.

Additional information

No response

@ghost ghost added the feature request Issue is related to a feature in the app label Mar 14, 2022
@litetex
Copy link
Member

litetex commented Mar 14, 2022

Sidenote:

Essentially, when the app detects google play services

As NewPipe is designed not to work with proprietary Google APIs like Google Play Services I don't think that this will/should be implemented.

@litetex litetex added the discussion This needs to be discussed before anything is done label Mar 15, 2022
@SchlSE
Copy link

SchlSE commented Mar 16, 2022

Couldn't microG be used as an compromise?

@litetex
Copy link
Member

litetex commented Mar 16, 2022

Couldn't microG be used as an compromise?

Not every device is equipped with microG.
Also NewPipe is designed to run standalone without any additional software requirement (besides a working Android version).

Also regarding the "shitstorm" I got when trying to increase the minSdk (#7602) I think the addition of requiring microG would cause an even bigger one.

@opusforlife2
Copy link
Collaborator

It is a pain to manually go to Google Takeout, deselect all, select YouTube, only select subscriptions, and wait 30 seconds to get the download, and import it into NewPipe. On a mobile device which makes it 100x harder.

Well yeah, but you only have to do it once.

@litetex litetex added the niche Only relevant to a very small amount of people label Mar 17, 2022
@anoraktrend
Copy link

Seeing as this would also be a way to get around the new potential sign-in requirements, would this possible addition be considered more seriously?

@SpectralPixel
Copy link

I feel like not having a way to easily import your subscriptions is a serious UX issue, regardless of whether "you only have to do it once".

I know that this app is mainly geared towards techies anyways, but I feel like NewPipe could appeal to a much larger audience if the setup process was more streamlined.

Therefore, I believe that this suggestion is quite the opposite of "niche".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This needs to be discussed before anything is done feature request Issue is related to a feature in the app niche Only relevant to a very small amount of people
Projects
None yet
Development

No branches or pull requests

5 participants