Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rotate popup suggestion? #8135

Open
5 tasks done
lsnch opened this issue Apr 3, 2022 · 10 comments
Open
5 tasks done

Enable rotate popup suggestion? #8135

lsnch opened this issue Apr 3, 2022 · 10 comments
Labels
feature request Issue is related to a feature in the app

Comments

@lsnch
Copy link

lsnch commented Apr 3, 2022

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Hi, I love your app :)

The button seems to be disabled for newpipe. Every other app has it, it's a really nifty little thing!

photo5353006960540236231

Why do you want this feature?

I hate auto-rotate, and newpipe always gets it wrong which orientation I want, so I have to go to notification shade and enable-disable auto-rotate to change orientation.

Additional information

No response

@lsnch lsnch added the feature request Issue is related to a feature in the app label Apr 3, 2022
@SameenAhnaf

This comment was marked as off-topic.

@lsnch
Copy link
Author

lsnch commented Apr 3, 2022

The main player can already be rotated with the [] button. But the search screen, comments, history have no way to go portrait after watching a video. The background player has the button, but not the main app. It'd nice to have a universal way to do this.

@opusforlife2
Copy link
Collaborator

newpipe always gets it wrong which orientation I want

I'm assuming you want to go back to portrait after watching a video. Try this. After the video ends and the Replay button appears, use the Back button or the Full Screen button to go back to portrait mode.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 3, 2022
@SameenAhnaf

This comment was marked as off-topic.

@lsnch
Copy link
Author

lsnch commented Apr 4, 2022

I'm assuming you want to go back to portrait after watching a video. Try this. After the video ends and the Replay button appears, use the Back button or the Full Screen button to go back to portrait mode.

No only then, but I can't remember exact scenarios. It has to do with switching between video and background, among other things. What you suggest is a workaround, like toggling rotate in notification shade. To me, the popup button feels infinitely more seamless.

PS. I've looked into this a bit more. It seems the popup button works as long as you don't press []. If you do, the app needs to be restarted. There must be some sort of flag connected to [] that disables popup (edit: rotate button suggestion that pops up, as seen on OP screenshot).

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Apr 4, 2022
@cbiere
Copy link

cbiere commented Apr 7, 2022

It really looks like the full screen button tells Android to enforce landscape mode for the app like games usually do. Thanks for the tip though. By ignoring the full screen button and just using the manual rotation button the issue is far less annoying.

@fhteagle
Copy link

I would prefer a settings option to disable Newpipe's rotation logic entirely. I manually set my rotation as needed. New pipe overrides this stubbornly and inconsistently, remains in landscape after backing out of full screen player, and worse yet disables my ability to set manual rotation. This often requires exiting newpipe completely to get back to portrait mode.

@lefuturiste
Copy link

what is the [] button, I don't have it

@locuturus
Copy link

If you have a large DPI setting, or use a tablet, the rotation problem is even worse.

Starting with what works (and remember I'm testing with 600+ DPI):

  1. Starting from portrait, if you rotate the phone and use the phone's rotation suggestion then newpipe rotates, but adopts a multi-column tablet UI so the video is not full screen. Rotating the phone back to portrait does prompt the system's rotate suggestion and so this works. So far this seems good to me.

Now we get into the problems that I face:

  1. Starting from portrait, if you tap on [ ] the video does not go full screen. Instead, NewPipe will enter the landscape multi column tablet UI as above, but now it's locked there*. Tapping [ ] again will actually start full screen. The full screen video player can rotate now but you can't return to the main app in portait*

  2. If you rotate the app to landscape using the system suggestion, as in 1., you get landscape tablet UI and you have the option to tap [ ]. If you do so, you get full screen video but you are locked to landscape app UI*.

*You can enable the system's auto rotate and then NewPipe rotates as expected without locking. This is not a good workaround though because very often users do not want autorotation in general.

@ghost
Copy link

ghost commented Mar 18, 2023

what is the [] button, I don't have it

The [] button is only displayed, when Auto-Rotate is turned off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

No branches or pull requests

7 participants