Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty playlist are not showed in playlist bookmarks when are more than one empty #8582

Closed
5 tasks done
LukasThyWalls opened this issue Jul 6, 2022 · 4 comments · Fixed by #9642
Closed
5 tasks done
Assignees
Labels
bug Issue is related to a bug playlist Anything to do with playlists in the app

Comments

@LukasThyWalls
Copy link

LukasThyWalls commented Jul 6, 2022

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.23.1

Steps to reproduce the bug

  1. Have multiple playlist. (In my case, i have four: "- PODCAST -" (Local), "- VER MÁS TARDE -" (Watch Later, Local), "Música" (Music, Local), and other user playlist (Subscribed Playlist). First one (- PODCAST -) have some videos, second one (- VER MÁS TARDE -) only one video, third one (Música), empty.

  2. I you go to any video and try to add to a playlist, it shows three options, as the local playlist are. That's fine.

  3. If you remove the video from the playlist - VER MÁS TARDE - (Watch Later), it still shows in the playlist bookmarks, the Música (Music) playlist dissapears.

  4. Then, if you go to any video to add to playlist, it only shows two options - PODCAST -, - VER MÁS TARDE - (Watch Later), and the Música (Music) playlist is gone.

  5. HOWEVER, if you add a video to the playlist - VER MÁS TARDE - (Watch Later), the Música (Music) playlist appears again everywhere.

Expected behavior

The empty playlist should be there always and not disappears, unless if it's decided that empty playlist should be removed altogether with its last video, but then the playlist should not come back (I wouldn't prefer that, but at least make sense).

Actual behavior

Some empty playlists appear and disappear in specific circumstances with no sense, at least in this case, when other playlist is empty or not.

Screenshots/Screen recordings

  1. Initial playlists:

NewPipe_2EmptyPlaylistIssue_1-AllPlaylist

  1. Initial add playlist options:

NewPipe_2EmptyPlaylistIssue_2-AllPlaylistAdd

  1. After removing video from - VER MÁS TARDE - (Watch Later):

NewPipe_2EmptyPlaylistIssue_3-NoPlaylist

  1. Add playlist options with - VER MÁS TARDE - (Watch Later) empty:

NewPipe_2EmptyPlaylistIssue_4-NoPlaylistAdd

  1. After adding a video in - VER MÁS TARDE - (Watch Later), the screenshot is the same as (1) and (2), Música (Music) playlist appears again everywhere.

Logs

No response

Affected Android/Custom ROM version

Android 10 (MIUI 12.0.10/QKQ1.190828.002)

Affected device model

Xiaomi Mi 9 Lite

Additional information

I'm aware than having empty playlist only can be done at the moment creating them in Add playlist options and later removing the videos, but the behavior should make sense: If you can have empty playlist, Newpipe should show all empty playlist, and if you can't have empty playlist, after removing the last video the playlist should be gone and don't come back.
I would prefer have empty playlist available (and i think it's what Newpipe devs want) but something is happening there than prevents show some empty playlist in specific circumstances.

Thanks!

@LukasThyWalls LukasThyWalls added the bug Issue is related to a bug label Jul 6, 2022
@Jared234
Copy link
Contributor

Jared234 commented Jan 7, 2023

While I was working on some other issues, I also found this bug.
I can work on it and will create a PR in the next few days.

@AudricV AudricV added the playlist Anything to do with playlists in the app label Jan 8, 2023
@PVTejas
Copy link

PVTejas commented Sep 14, 2023

This bug has reappeared in v0.25.2 with a minor difference. The second empty playlist is visible in the bookmarked playlist tab, but is unavailable when adding a new video to a playlist.

@LukasThyWalls
Copy link
Author

Yes, i confirmed that. The 4º screenshot in the OP is still happening in v0.25.2.

What i don't know is someone can open this issue again (i can't), or we need to create a new issue.

@PVTejas
Copy link

PVTejas commented Sep 14, 2023

I'm thinking of waiting 24h for a dev reply. If there's nothing, I'll create a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug playlist Anything to do with playlists in the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants