Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign for Video Long Press Menu & Always Ask Share Menu #9730

Open
6 tasks done
SameenAhnaf opened this issue Jan 31, 2023 · 3 comments
Open
6 tasks done

Redesign for Video Long Press Menu & Always Ask Share Menu #9730

SameenAhnaf opened this issue Jan 31, 2023 · 3 comments
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface

Comments

@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Jan 31, 2023

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Auto-play and external player options will be removed from settings. These functionalities could be replaced into a single menu. Also, Show Info and Always Ask will work the same for shared videos.

This menu should have two parts: upper part and lower part.

Upper part

Video Thumbnail Video title Resolution drop-down menu
Channel title Captions drop-down menu

Lower part

External Audio External Video Description Comments Playlist Thumbnail
Background Play on Main Share Download Remove
Popup Play on Another Tab Open In Browser Mark as Watched/Unwatched Copy
Kodi Blacklist Add to Playlist Channel Move

Long press on red highlighted icons will enqueue the video on respective cases. Hide first column for audio-only platforms. Fifth column is exclusive for local playlists only.

Why do you want this feature?

Possible solution for #6500 and #6181, #3642, #5591, #6347, #3700, #4779. Also, it will be possible to directly cast any shared video to Kodi.

Additional information

Document 2_1

@SameenAhnaf SameenAhnaf added feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface labels Jan 31, 2023
@opusforlife2
Copy link
Collaborator

It's quite hard to visualise this. Mind showing a picture?

@SameenAhnaf
Copy link
Collaborator Author

SameenAhnaf commented Feb 5, 2023

@melihozkurt Sorry for the pinge. If you can fully understand the concept, could you please send a mockup based on the issue description? Thanks in advance.

If you are not free or unable to understand, that is also fine. I'll submit a drawing soon in that case.

@melihozkurt
Copy link

If these are options for Video Long Press Menu & Always Ask Share Menu I have to say one thing. Show Info.

What you tell is like a mini-app just for a menu. If you set it to 'Show Info' you can reach channel name, subscribe, captions, resolution, share...

Yes, Newpipe needs some refreshments. At #9716, Video/PIP/Only Audio buttons thought of as a mode.
So if you add a new link, it will continue to respect the selected one. Playing music in the background already, when you add the next one, it will respect that setting. If you add while in Pop-Up, it will continue in Pop-up. If you want to go back to video mode, press video like now or just switch it. This can be valid solution for continuity issue of opening links.


Newpipe Share sheet options can be;

  • Play Now (add to the end of the already playing list and start it)
  • Save (add to Playlist, add to the Stream, a.k.a already playing/ongoing playlist, also needs to be in the list)
  • Play in Respective Player
  • Add in Queue in Respective Player

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app GUI Issue is related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

3 participants