Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapping/clicking on an empty comment crashes the app #9774

Closed
6 tasks done
zachintolinux opened this issue Feb 9, 2023 · 2 comments · Fixed by #9777
Closed
6 tasks done

Tapping/clicking on an empty comment crashes the app #9774

zachintolinux opened this issue Feb 9, 2023 · 2 comments · Fixed by #9777
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface

Comments

@zachintolinux
Copy link

zachintolinux commented Feb 9, 2023

Checklist

  • I am able to reproduce the bug with the latest version.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.25.0

Steps to reproduce the bug

  1. Search for the video "Tesla can't build a car" by "Louis Rossmann: RANDOM LIVE"
  2. Tap/click on the empty comment
  3. App should crash
  4. Open the app and repeat steps 1-2
  5. The error report should appear

Expected behavior

I expected the empty comment to have full text after expanding said comment.

Actual behavior

As I mentioned before, the app crashes when I tap on the empty comment in that video.

Screenshots/Screen recordings

Screenshot_20230209-130010

Logs

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: US
  • Content Language: en-US
  • App Language: en_US
  • Service: none
  • Version: 0.25.0
  • OS: Linux Android 13 - 33
Crash log

java.lang.StringIndexOutOfBoundsException: length=0; index=-1
	at java.lang.String.charAt(Native Method)
	at org.schabi.newpipe.info_list.holder.CommentsMiniInfoItemHolder.toggleEllipsize(CommentsMiniInfoItemHolder.java:255)
	at org.schabi.newpipe.info_list.holder.CommentsMiniInfoItemHolder.lambda$updateFromItem$1(CommentsMiniInfoItemHolder.java:145)
	at org.schabi.newpipe.info_list.holder.CommentsMiniInfoItemHolder.$r8$lambda$0fvlfbx4UGcHQ9bF6ke9G9oLHSM(CommentsMiniInfoItemHolder.java:0)
	at org.schabi.newpipe.info_list.holder.CommentsMiniInfoItemHolder$$ExternalSyntheticLambda1.onClick(R8$$SyntheticClass:0)
	at android.view.View.performClick(View.java:7506)
	at android.view.View.performClickInternal(View.java:7483)
	at android.view.View.-$$Nest$mperformClickInternal(Unknown Source:0)
	at android.view.View$PerformClick.run(View.java:29341)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7879)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ExecInit.main(ExecInit.java:49)
	at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
	at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:355)


Affected Android/Custom ROM version

Android 13/GrapheneOS

Affected device model

Google Pixel 6a

Additional information

DISCLAIMER: This is the first time I've encountered an issue like this.

Keep that in mind as this could be either a one-time occurrence or one of many randomized occurrences across multiple videos.

@zachintolinux zachintolinux added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Feb 9, 2023
@SameenAhnaf SameenAhnaf added GUI Issue is related to the graphical user interface and removed needs triage Issue is not yet ready for PR authors to take up labels Feb 10, 2023
@Stypox Stypox added this to v0.25.1 Feb 11, 2023
@slavalamp
Copy link

slavalamp commented Feb 13, 2023

the comment text missing also seems to have been fixed in the extractor? they got broken because they have hashtags

TeamNewPipe/NewPipeExtractor#1021

@AudricV
Copy link
Member

AudricV commented Feb 13, 2023

the comment text missing also seems to have been fixed in the extractor?

In fact, the fix doesn't really fix the issue, but I found how to really fix this.

Anyway, that's outside the scope of this issue: see TeamNewPipe/NewPipeExtractor#1019.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants