jsoncons trait longer compatible with latest release

[dmazzella]

What happened?

A bug happened!

With master version of jwt-cpp and jsoncons at 1.2.0

traits.h(93,28): error C2039: 'object_value': non è un membro di 'jsoncons::basic_json<char,jsoncons::sorted_policy,std::allocator<char>>'

traits.h(98,27): error C2039: 'array_value': non è un membro di 'jsoncons::basic_json<char,jsoncons::sorted_policy,std::allocator<char>>'

P.S.
updated static_assert from static_assert(jsoncons::version().minor >= 167, "A higher version of jsoncons is required!");

to

static_assert(jsoncons::version().minor >= 167 || (jsoncons::version().major > 0), "A higher version of jsoncons is required!");

How To Reproduce?

#include <iostream>

// #define USE_NLOHMANN_JSON

#pragma warning(push)
#pragma warning(disable: 4267)
#pragma warning(disable: 4244)
#define JWT_DISABLE_PICOJSON
#if defined(USE_NLOHMANN_JSON)
#include "jwt-cpp/traits/nlohmann-json/traits.h"
#else
#include "jsoncons/json.hpp"
#include "jwt-cpp/traits/danielaparker-jsoncons/traits.h"
#endif
#pragma warning(pop)

std::string _private_key = R"(-----BEGIN PRIVATE KEY-----
MIIEvwIBADANBgkqhkiG9w0BAQEFAASCBKkwggSlAgEAAoIBAQC4ZtdaIrd1BPIJ
tfnF0TjIK5inQAXZ3XlCrUlJdP+XHwIRxdv1FsN12XyMYO/6ymLmo9ryoQeIrsXB
XYqlET3zfAY+diwCb0HEsVvhisthwMU4gZQu6TYW2s9LnXZB5rVtcBK69hcSlA2k
ZudMZWxZcj0L7KMfO2rIvaHw/qaVOE9j0T257Z8Kp2CLF9MUgX0ObhIsdumFRLaL
DvDUmBPr2zuh/34j2XmWwn1yjN/WvGtdfhXW79Ki1S40HcWnygHgLV8sESFKUxxQ
mKvPUTwDOIwLFL5WtE8Mz7N++kgmDcmWMCHc8kcOIu73Ta/3D4imW7VbKgHZo9+K
3ESFE3RjAgMBAAECggEBAJTEIyjMqUT24G2FKiS1TiHvShBkTlQdoR5xvpZMlYbN
tVWxUmrAGqCQ/TIjYnfpnzCDMLhdwT48Ab6mQJw69MfiXwc1PvwX1e9hRscGul36
ryGPKIVQEBsQG/zc4/L2tZe8ut+qeaK7XuYrPp8bk/X1e9qK5m7j+JpKosNSLgJj
NIbYsBkG2Mlq671irKYj2hVZeaBQmWmZxK4fw0Istz2WfN5nUKUeJhTwpR+JLUg4
ELYYoB7EO0Cej9UBG30hbgu4RyXA+VbptJ+H042K5QJROUbtnLWuuWosZ5ATldwO
u03dIXL0SH0ao5NcWBzxU4F2sBXZRGP2x/jiSLHcqoECgYEA4qD7mXQpu1b8XO8U
6abpKloJCatSAHzjgdR2eRDRx5PMvloipfwqA77pnbjTUFajqWQgOXsDTCjcdQui
wf5XAaWu+TeAVTytLQbSiTsBhrnoqVrr3RoyDQmdnwHT8aCMouOgcC5thP9vQ8Us
rVdjvRRbnJpg3BeSNimH+u9AHgsCgYEA0EzcbOltCWPHRAY7B3Ge/AKBjBQr86Kv
TdpTlxePBDVIlH+BM6oct2gaSZZoHbqPjbq5v7yf0fKVcXE4bSVgqfDJ/sZQu9Lp
PTeV7wkk0OsAMKk7QukEpPno5q6tOTNnFecpUhVLLlqbfqkB2baYYwLJR3IRzboJ
FQbLY93E8gkCgYB+zlC5VlQbbNqcLXJoImqItgQkkuW5PCgYdwcrSov2ve5r/Acz
FNt1aRdSlx4176R3nXyibQA1Vw+ztiUFowiP9WLoM3PtPZwwe4bGHmwGNHPIfwVG
m+exf9XgKKespYbLhc45tuC08DATnXoYK7O1EnUINSFJRS8cezSI5eHcbQKBgQDC
PgqHXZ2aVftqCc1eAaxaIRQhRmY+CgUjumaczRFGwVFveP9I6Gdi+Kca3DE3F9Pq
PKgejo0SwP5vDT+rOGHN14bmGJUMsX9i4MTmZUZ5s8s3lXh3ysfT+GAhTd6nKrIE
kM3Nh6HWFhROptfc6BNusRh1kX/cspDplK5x8EpJ0QKBgQDWFg6S2je0KtbV5PYe
RultUEe2C0jYMDQx+JYxbPmtcopvZQrFEur3WKVuLy5UAy7EBvwMnZwIG7OOohJb
vkSpADK6VPn9lbqq7O8cTedEHttm6otmLt8ZyEl3hZMaL3hbuRj6ysjmoFKx6CrX
rK0/Ikt5ybqUzKCMJZg2VKGTxg==
-----END PRIVATE KEY-----
)";

std::string _public_key = R"(-----BEGIN PUBLIC KEY-----
MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAuGbXWiK3dQTyCbX5xdE4
yCuYp0AF2d15Qq1JSXT/lx8CEcXb9RbDddl8jGDv+spi5qPa8qEHiK7FwV2KpRE9
83wGPnYsAm9BxLFb4YrLYcDFOIGULuk2FtrPS512Qea1bXASuvYXEpQNpGbnTGVs
WXI9C+yjHztqyL2h8P6mlThPY9E9ue2fCqdgixfTFIF9Dm4SLHbphUS2iw7w1JgT
69s7of9+I9l5lsJ9cozf1rxrXX4V1u/SotUuNB3Fp8oB4C1fLBEhSlMcUJirz1E8
AziMCxS+VrRPDM+zfvpIJg3JljAh3PJHDiLu902v9w+Iplu1WyoB2aPfitxEhRN0
YwIDAQAB
-----END PUBLIC KEY-----)";

int main()
{
#if defined(USE_NLOHMANN_JSON)
	using jwt_traits = jwt::traits::nlohmann_json;
#else
	using jwt_traits = jwt::traits::danielaparker_jsoncons;
#endif

	try
	{
		jwt::algorithm::rs256 rs256_private_key = jwt::algorithm::rs256{ "", _private_key, "", "" };
		std::cout << "private: " << rs256_private_key.name() << std::endl;

		jwt::algorithm::rs256 rs256_public_key = jwt::algorithm::rs256{ _public_key};
		std::cout << "pub: "  << rs256_public_key.name() << std::endl;

		auto access_token = jwt::create<jwt_traits>()
			.set_issuer("issuer")
			.set_type("JWT")
			.set_audience("aud")
			.set_issued_at(std::chrono::system_clock::now())
			.set_not_before(std::chrono::system_clock::now())
			.set_expires_at(std::chrono::system_clock::now() + std::chrono::seconds{ 3600 }).sign(rs256_private_key);
		std::cout << "Access Created: " << access_token << std::endl;

		const jwt::decoded_jwt<jwt_traits> access_decoded = jwt::decode<jwt_traits>(access_token);
		std::cout << "Access Token: " << access_decoded.get_payload() << std::endl;

		auto p = access_decoded.get_payload_json();

		jwt::verify<jwt_traits>().allow_algorithm(rs256_public_key).with_issuer("issuer").leeway(60UL).verify(access_decoded);
		std::cout << "Access Token Verified" << std::endl;
	}
	catch (const std::exception &e)
	{
		std::cerr << "Access Token Verification Failed: " << e.what() << std::endl;
	}
}

Version

0.7.0

What OS are you seeing the problem on?

Windows

What compiler are you seeing the problem on?

MSVC

Relevant log output

Compilazione avviata alle 09:09...
1>------ Inizio compilazione: Progetto: ConsoleApplication, Configurazione: Release ARM64 ------
1>ConsoleApplication.cpp
1>C:\Users\damianomazzella\source\repos\Others\jwt-cpp\ConsoleApplication\third_party\jwt-cpp\include\jwt-cpp\traits\danielaparker-jsoncons\traits.h(93,28): error C2039: 'object_value': non è un membro di 'jsoncons::basic_json<char,jsoncons::sorted_policy,std::allocator<char>>'
1>(compilazione del file di origine 'ConsoleApplication.cpp')
1>    C:\Users\damianomazzella\source\repos\Others\jwt-cpp\ConsoleApplication\third_party\jsoncons\jsoncons\basic_json.hpp(389,11):
1>    vedere la dichiarazione di 'jsoncons::basic_json<char,jsoncons::sorted_policy,std::allocator<char>>'
1>C:\Users\damianomazzella\source\repos\Others\jwt-cpp\ConsoleApplication\third_party\jwt-cpp\include\jwt-cpp\traits\danielaparker-jsoncons\traits.h(98,27): error C2039: 'array_value': non è un membro di 'jsoncons::basic_json<char,jsoncons::sorted_policy,std::allocator<char>>'
1>(compilazione del file di origine 'ConsoleApplication.cpp')
1>    C:\Users\damianomazzella\source\repos\Others\jwt-cpp\ConsoleApplication\third_party\jsoncons\jsoncons\basic_json.hpp(389,11):
1>    vedere la dichiarazione di 'jsoncons::basic_json<char,jsoncons::sorted_policy,std::allocator<char>>'
1>Compilazione progetto "ConsoleApplication.vcxproj" NON COMPLETATA.
========== Compilazione: 0 completato/i, 1 non riuscito/i, 0 aggiornato/i, 0 ignorato/i ==========
========== Compilazione completato alle 09:09 e ha richiesto 01,772 secondi ==========

Code of Conduct

• I agree to follow this project's Code of Conduct

[prince-chrismc]

I would strongly encourage you to update the trait definition to be compatible with the newest release. If younise that library you'll be best suited for it.

It does seem the range needs set since there's a breaking change

[dmazzella]

I'm on master of jwt-cpp, and on the latest release of jsoncons 1.2.0.

The Version 0.7.0 in the issue is forced by template, but I use the commit 482f4f1c050fb59db7f824636d8ab70ef8525544

Do you want me to do any particular tests?

[prince-chrismc]

Well the logs you posted show it does not compile, looks like the internals of jsocons have changed.

Maybe update the trait implementation to work with the new version?

[dmazzella]

602

[prince-chrismc]

First reported in #366