Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling unanswered toxav call locks uninitialied mutex #1194

Closed
sphaerophoria opened this issue Sep 21, 2018 · 0 comments · Fixed by #1195
Closed

Cancelling unanswered toxav call locks uninitialied mutex #1194

sphaerophoria opened this issue Sep 21, 2018 · 0 comments · Fixed by #1195
Labels
P3 Low priority
Milestone

Comments

@sphaerophoria
Copy link

sphaerophoria commented Sep 21, 2018

Edit: My apologies for the initial bug report, I thought the scope of this problem was much larger and was only being shown on MSVC.

When we create a toxav call we do not initialize any of our mutexes until we activate the call. If we then cancel the call we lock/unlock an uninitialized mutex. On MSVC this results in a segfault due to the pthread_mutex_t type being a typedeffed pointer.

Example in the following image.

image

Note that mutex[0] == NULL. Visual studio made a mistake in where it places the (X) in this image, the access violation occurs in pthread_mutex_unlock.

@sphaerophoria sphaerophoria changed the title Pthread mutex are not initialized correctly in most circumstances Pthread mutex are not initialized correctly in some circumstances Sep 21, 2018
@sphaerophoria sphaerophoria changed the title Pthread mutex are not initialized correctly in some circumstances Cancelling unanswered toxav call locks uninitialied mutex Sep 21, 2018
@robinlinden robinlinden modified the milestone: v0.2.11 Mar 20, 2020
@iphydf iphydf added the P3 Low priority label Feb 4, 2022
@iphydf iphydf added this to the v0.2.8 milestone Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low priority
Development

Successfully merging a pull request may close this issue.

3 participants