Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOX_VERSION_PATCH isn't in sync with the version #474

Closed
yurivict opened this issue Feb 13, 2017 · 3 comments
Closed

TOX_VERSION_PATCH isn't in sync with the version #474

yurivict opened this issue Feb 13, 2017 · 3 comments
Labels
bug Bug fix for the user, not a fix to a build script P1 High priority
Milestone

Comments

@yurivict
Copy link
Member

TOX_VERSION_PATCH=5 when the version is 0.1.6

@SkyzohKey SkyzohKey added bug Bug fix for the user, not a fix to a build script P1 High priority labels Feb 13, 2017
@SkyzohKey SkyzohKey added this to the v0.1.8 milestone Feb 13, 2017
@cebe cebe modified the milestones: v0.1.7, v0.1.8 Feb 14, 2017
@cebe
Copy link
Member

cebe commented Feb 14, 2017

@SkyzohKey I think this should be fixed in the next version already, not one after :)

@nurupo
Copy link
Member

nurupo commented Feb 26, 2017

This should have been caught by tests on Travis, but Travis build for some reason doesn't fail when tests fail: https://travis-ci.org/TokTok/c-toxcore/jobs/195715912#L2207-L2230. Don't really understand why it doesn't fail, it's being included into phase which has set -e.

@cebe
Copy link
Member

cebe commented Feb 26, 2017

phase has set -e but as far as I see the script it calls does not have set -e: https://github.com/TokTok/c-toxcore/blob/b2d04eae9d9b76523b877a9e5efd5989f83b143d/other/travis/toxcore-script

edit: nvm, that should still work...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix for the user, not a fix to a build script P1 High priority
Development

No branches or pull requests

5 participants