Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review all public API for 0.3.0 #655

Open
nurupo opened this issue Jan 9, 2018 · 1 comment
Open

Review all public API for 0.3.0 #655

nurupo opened this issue Jan 9, 2018 · 1 comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. help wanted Extra attention is needed P3 Low priority test Adding missing tests, refactoring tests; no production code change
Milestone
v0.3.0

Comments

@nurupo
Copy link
Member

nurupo commented Jan 9, 2018

I found in IRC logs that porting TES API to use APIDSL was an API breaking change at some point in late 2016, so I guess we settled on #310 which didn't break anything (or did it? I didn't check), leaving the breaking changes for 0.2.0.

In any case, it makes sense to review all public API before 0.2.0 just in case we want to change something.
@nurupo nurupo added this to the v0.2.0 milestone Jan 9, 2018
@SkyzohKey SkyzohKey added help wanted Extra attention is needed CAT:code_cleanup labels Jan 9, 2018
@iphydf iphydf modified the milestones: v0.2.0-RC1, v0.2.0 Jan 14, 2018
@iphydf
Copy link
Member

iphydf commented Feb 19, 2018

We weren't ready for 0.2.0, but now it's too late to back out the API changes, so we won't get any more breakages in for now. Deferring to 0.3.0.

@iphydf iphydf modified the milestones: v0.2.0, v0.3.0 Feb 19, 2018
@iphydf iphydf changed the title Review all public API for 0.2.0 Review all public API for 0.3.0 Feb 19, 2018
@iphydf iphydf added P3 Low priority refactor Refactoring production code, eg. renaming a variable, not affecting semantics cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. and removed code cleanup refactor Refactoring production code, eg. renaming a variable, not affecting semantics labels Apr 27, 2020
@iphydf iphydf added the test Adding missing tests, refactoring tests; no production code change label May 5, 2020
@settings settings bot removed the coverage label Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. help wanted Extra attention is needed P3 Low priority test Adding missing tests, refactoring tests; no production code change
Milestone
v0.3.0
Development

No branches or pull requests
3 participants
@nurupo @SkyzohKey @iphydf