Skip to content

Commit 879593e

Browse files
committed
Clean up Windows Start Menu
1 parent 78ba8d8 commit 879593e

File tree

1 file changed

+11
-21
lines changed

1 file changed

+11
-21
lines changed

packaging/NSIS/Ultimaker-Cura.nsi.jinja

+11-21
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,11 @@
1616
!define REG_APP_PATH "Software\Microsoft\Windows\CurrentVersion\App Paths\${APP_NAME}-${VERSION}"
1717
!define UNINSTALL_PATH "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APP_NAME}-${VERSION}"
1818

19-
!define REG_START_MENU "Start Menu Folder"
19+
!define REG_START_MENU "Start Menu Shortcut"
2020

2121
;Require administrator access
2222
RequestExecutionLevel admin
2323

24-
var SM_Folder
25-
2624
######################################################################
2725

2826
VIProductVersion "${VIVERSION}"
@@ -68,7 +66,6 @@ InstallDir "$PROGRAMFILES64\${APP_NAME}"
6866
!define MUI_STARTMENUPAGE_REGISTRY_ROOT "${REG_ROOT}"
6967
!define MUI_STARTMENUPAGE_REGISTRY_KEY "${UNINSTALL_PATH}"
7068
!define MUI_STARTMENUPAGE_REGISTRY_VALUENAME "${REG_START_MENU}"
71-
!insertmacro MUI_PAGE_STARTMENU Application $SM_Folder
7269
!endif
7370

7471
!insertmacro MUI_PAGE_INSTFILES
@@ -108,25 +105,21 @@ WriteUninstaller "$INSTDIR\uninstall.exe"
108105

109106
!ifdef REG_START_MENU
110107
!insertmacro MUI_STARTMENU_WRITE_BEGIN Application
111-
CreateDirectory "$SMPROGRAMS\$SM_Folder"
112-
CreateShortCut "$SMPROGRAMS\$SM_Folder\${APP_NAME}.lnk" "$INSTDIR\${MAIN_APP_EXE}"
113-
CreateShortCut "$SMPROGRAMS\$SM_Folder\Uninstall ${APP_NAME}.lnk" "$INSTDIR\uninstall.exe"
108+
CreateShortCut "$SMPROGRAMS\${APP_NAME}.lnk" "$INSTDIR\${MAIN_APP_EXE}"
114109

115110
!ifdef WEB_SITE
116111
WriteIniStr "$INSTDIR\UltiMaker Cura website.url" "InternetShortcut" "URL" "${WEB_SITE}"
117-
CreateShortCut "$SMPROGRAMS\$SM_Folder\UltiMaker Cura website.lnk" "$INSTDIR\UltiMaker Cura website.url"
112+
CreateShortCut "$SMPROGRAMS\UltiMaker Cura website.lnk" "$INSTDIR\UltiMaker Cura website.url"
118113
!endif
119114
!insertmacro MUI_STARTMENU_WRITE_END
120115
!endif
121116

122117
!ifndef REG_START_MENU
123-
CreateDirectory "$SMPROGRAMS\{{ app_name }}"
124-
CreateShortCut "$SMPROGRAMS\{{ app_name }}\${APP_NAME}.lnk" "$INSTDIR\${MAIN_APP_EXE}"
125-
CreateShortCut "$SMPROGRAMS\{{ app_name }}\Uninstall ${APP_NAME}.lnk" "$INSTDIR\uninstall.exe"
118+
CreateShortCut "$SMPROGRAMS\${APP_NAME}.lnk" "$INSTDIR\${MAIN_APP_EXE}"
126119

127120
!ifdef WEB_SITE
128121
WriteIniStr "$INSTDIR\UltiMaker Cura website.url" "InternetShortcut" "URL" "${WEB_SITE}"
129-
CreateShortCut "$SMPROGRAMS\{{ app_name }}\UltiMaker Cura website.lnk" "$INSTDIR\UltiMaker Cura website.url"
122+
CreateShortCut "$SMPROGRAMS\UltiMaker Cura website.lnk" "$INSTDIR\UltiMaker Cura website.url"
130123
!endif
131124
!endif
132125

@@ -184,22 +177,19 @@ Delete "$INSTDIR\${APP_NAME} website.url"
184177
RmDir /r /REBOOTOK "$INSTDIR"
185178

186179
!ifdef REG_START_MENU
187-
!insertmacro MUI_STARTMENU_GETFOLDER "Application" $SM_Folder
188-
Delete "$SMPROGRAMS\$SM_Folder\${APP_NAME}.lnk"
189-
Delete "$SMPROGRAMS\$SM_Folder\Uninstall ${APP_NAME}.lnk"
180+
Delete "$SMPROGRAMS\${APP_NAME}.lnk"
181+
Delete "$SMPROGRAMS\Uninstall ${APP_NAME}.lnk"
190182
!ifdef WEB_SITE
191-
Delete "$SMPROGRAMS\$SM_Folder\UltiMaker Cura website.lnk"
183+
Delete "$SMPROGRAMS\UltiMaker Cura website.lnk"
192184
!endif
193-
RmDir "$SMPROGRAMS\$SM_Folder"
194185
!endif
195186

196187
!ifndef REG_START_MENU
197-
Delete "$SMPROGRAMS\{{ app_name }}\${APP_NAME}.lnk"
198-
Delete "$SMPROGRAMS\{{ app_name }}\Uninstall ${APP_NAME}.lnk"
188+
Delete "$SMPROGRAMS\${APP_NAME}.lnk"
189+
Delete "$SMPROGRAMS\Uninstall ${APP_NAME}.lnk"
199190
!ifdef WEB_SITE
200-
Delete "$SMPROGRAMS\{{ app_name }}\UltiMaker Cura website.lnk"
191+
Delete "$SMPROGRAMS\UltiMaker Cura website.lnk"
201192
!endif
202-
RmDir "$SMPROGRAMS\{{ app_name }}"
203193
!endif
204194

205195
!insertmacro APP_UNASSOCIATE "stl" "Cura.model"

0 commit comments

Comments
 (0)