-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E-AC-3 JOC file decode produces distorted output #17
Comments
Copyright Maybe a short section? |
30sec clip -17.84 lufsDDP.zip Re bit depth, everything RIFF decoded is tagged 16bits in wav header. |
Distortion and no 24 bit out for RIFF decoding, yeah. The only thing I'm doing with Cavern is decoding ddp with atmos to RIFF. |
30sec clip -17.84 lufsDDP_Reference Player_trimmed for size.zip 16 ch 24bit digital recording of reference player output. Had to be trimmed, front and back, for the zip to fit in the 25MB attachment limit here. ADM output of canvernizeGUI, played back in adobe audition, also sounds distorted. |
This is the full clip: https://drive.google.com/file/d/12Uv0gNKNS6IlpMmZall8EqKbZvs-LF5c/view?usp=sharing FYI it still won't be time aligned with the encoded version because the digital recording is manually started and stopped, before/after the player is started and stops. I suppose if you trimmed of everything before the first non-zero sample, it would start at the right place. Please let me know, after you've grabbed it and confirmed, and I'll take it down. |
There are two types of JOC coding, coarse and sparse. Coarse, which is widely used by movies, works without issues, sparse (found in some versions of amaze) doesn't, as the documentation is incorrect about it. I'll contact Dolby about this, but the fix to the standard never comes fast. |
All of these are in JointObjectCodingTables.cs. |
That's in QuadratureMirrorFilterBank.cs, sorry. |
After trying (and failing in) every interpretation of the standard's related parts, I've sent a mail to Dolby. If they reply, I'll reopen and fix this issue. |
Sir, after all they didn't reply? |
No. |
Version 1.5
Decoding E-AC-3 JOC music files (commercial and self encoded) to riff produces distorted results. I am comparing to the reference player.
7.1.4 layout to integer RIFF.
Also RIFF float settings produce 16bit results
The text was updated successfully, but these errors were encountered: