Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-AC-3 JOC file decode produces distorted output #17

Closed
dts350z opened this issue Oct 1, 2022 · 19 comments
Closed

E-AC-3 JOC file decode produces distorted output #17

dts350z opened this issue Oct 1, 2022 · 19 comments
Assignees
Labels

Comments

@dts350z
Copy link

dts350z commented Oct 1, 2022

Version 1.5

Decoding E-AC-3 JOC music files (commercial and self encoded) to riff produces distorted results. I am comparing to the reference player.

7.1.4 layout to integer RIFF.

Also RIFF float settings produce 16bit results

@dts350z
Copy link
Author

dts350z commented Oct 1, 2022

Copyright

Maybe a short section?

@dts350z
Copy link
Author

dts350z commented Oct 1, 2022

30sec clip -17.84 lufsDDP.zip
Drums in top channels are distorted.

Re bit depth, everything RIFF decoded is tagged 16bits in wav header.

@dts350z
Copy link
Author

dts350z commented Oct 1, 2022

Distortion and no 24 bit out for RIFF decoding, yeah.

The only thing I'm doing with Cavern is decoding ddp with atmos to RIFF.

@dts350z
Copy link
Author

dts350z commented Oct 2, 2022

30sec clip -17.84 lufsDDP_Reference Player_trimmed for size.zip

16 ch 24bit digital recording of reference player output. Had to be trimmed, front and back, for the zip to fit in the 25MB attachment limit here.

ADM output of canvernizeGUI, played back in adobe audition, also sounds distorted.

@dts350z
Copy link
Author

dts350z commented Oct 2, 2022

This is the full clip:

https://drive.google.com/file/d/12Uv0gNKNS6IlpMmZall8EqKbZvs-LF5c/view?usp=sharing

FYI it still won't be time aligned with the encoded version because the digital recording is manually started and stopped, before/after the player is started and stops.

I suppose if you trimmed of everything before the first non-zero sample, it would start at the right place.

Please let me know, after you've grabbed it and confirmed, and I'll take it down.

@VoidXH
Copy link
Owner

VoidXH commented Oct 5, 2022

There are two types of JOC coding, coarse and sparse. Coarse, which is widely used by movies, works without issues, sparse (found in some versions of amaze) doesn't, as the documentation is incorrect about it. I'll contact Dolby about this, but the fix to the standard never comes fast.

@VoidXH
Copy link
Owner

VoidXH commented Oct 5, 2022

All of these are in JointObjectCodingTables.cs.

@VoidXH
Copy link
Owner

VoidXH commented Oct 5, 2022

That's in QuadratureMirrorFilterBank.cs, sorry.

@VoidXH VoidXH self-assigned this Oct 7, 2022
@VoidXH VoidXH added the bug label Oct 7, 2022
@VoidXH
Copy link
Owner

VoidXH commented Nov 1, 2022

After trying (and failing in) every interpretation of the standard's related parts, I've sent a mail to Dolby. If they reply, I'll reopen and fix this issue.

@VoidXH VoidXH closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2022
@bluewidy
Copy link

Sir, after all they didn't reply?

@VoidXH
Copy link
Owner

VoidXH commented Nov 16, 2022

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@dts350z @VoidXH @bluewidy and others