-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FFAR in Origin trials #322
Comments
Thanks for the questions!
Being in OT should indeed be enabling both fenced frames and FFAR automatically. Could you please confirm which Chrome version you are using?
You are right, fenced frames are using a unique partition for all cookies while iframes don't do that. Even for the testing phase, fenced frames cookies are set up to behave as they would in the long term. |
Thank you for the answers. My assumption about FFAR was based on two observations:
My version: |
(Catching up on this thread after the holidays) Thanks for the details! Just to correct/clarify my earlier response, the OT being enabled itself is not sufficient for all users' browsers to be able to access the privacy sandbox APIs. A given user's participation is controlled by Chrome based on whether they are in the enabled experiment group or not. A user that is in the experiment group will automatically have the "Privacy Sandbox Ads APIs" flag enabled but not otherwise. So your observation that everything works after enabling the flag is correct. Although I would expect that without the flag enabled, not just FFAR but FLEDGE and fenced frames will also not work. |
Hi, One thing that we fixed in our side is that ad (response from render url) didn't contain Origin Trial header / meta. But unfortunately not all - in some cases OT was disabled due to "insecure context":
Appreciate for your help! |
Thanks for the details! |
Hi, To sum up the problem we observed:
The nested iframe (with ad) is marked as insecure! But if srcdoc is not empty: Example: <iframe id="with_empty_srcdoc" srcdoc="" width="200" height="200" ></iframe>
<iframe id="without_srcdoc" width="200" height="200" ></iframe>
<iframe id="with_non_empty_srcdoc" srcdoc="<iframe src='https://creativecdn.com/creatives?id=6F5AeFDSQ4j6D1XoJzHb&cs=320x100&c=kQKZEgHd2MX0GUG9VHAS&s=rtbhfledge'/>" width="200" height="200" ></iframe>
<script>
var ad_url = 'https://creativecdn.com/creatives?id=6F5AeFDSQ4j6D1XoJzHb&cs=320x100&c=kQKZEgHd2MX0GUG9VHAS&s=rtbhfledge'
document.querySelector('#with_empty_srcdoc')
.contentDocument.write("<h1>Injected from parent frame</h1><script>console.log(window.isSecureContext);<\/script><iframe src='"+ad_url+"'/>")
document.querySelector('#without_srcdoc')
.contentDocument.write("<h1>Injected from parent frame</h1><script>console.log(window.isSecureContext);<\/script><iframe src='"+ad_url+"'/>")
</script> The first one iframe is marked as insecure: But second one and third one are secure: @shivanigithub could you please let me know if this is indeed intended behaviour? It makes real life OT testing much harder |
cc @mikewest for thoughts on the impact of srcdoc attribute on whether the context is considered secure. |
There shouldn't be a meaningful distinction between I'd suggest filing a bug against Chromium at https://crbug.com/new. |
Thanks a lot! Thanks, |
Can you help me understand why this issue has a higher priority? It seems like simply omitting the |
I agree that omitting problematic attribute is good workaround as long as there is an easy way to do this. Currently in many cases Publisher uses Google Ad Manager to create iframe: as we observed GAM creates iframe with srcdoc. I asked to prioritize the issue to have possibility to test FFAR (and possible other Privacy Sandbox API) during FOT. |
@zhengweiwithoutthei in case you know why GAM creates iframes with an empty srcdoc, and in case this isn't actually needed on modern Chrome |
We are working on solving this issue by removing the srcdoc from GPT. It was intended as a temporary solution for a bug that was already fixed in Chrome. |
@zhengweiwithoutthei friendly reminder. Do you have maybe any update on this issue? |
We are close to remove it from GPT completely. ETA 2 weeks. |
The empty srcdoc has been removed from GPT. |
Hi,
We have noticed that for users who participate in OT, some features are not available - especially Fenced Frame Ad Reporting.
Let's consider case:
For User in OT: FFAR seams to be not available:
Condition "window.fence && fence.reportEvent" are not met.
But when User in OT enable flag 'Privacy Sandbox Ads APIs' - FFAR starts to be available and request are send.
I was wondering if it is possible to turn on FFAR for OT?
Would it be possible to provide full set of flags that has to be enabled to have exactly the same setting as user in OT?
Second thing - more related to cookies - we observe that if ad is rendered by iframe (with opaque url) request send to render_url contains cookies in header, but for FF it is not.
I suppose it is related to partitioned cookies (CHIPS), but is there other logic for iframe than for FF ?
I am aware that eventually cookie will not be available, but for current stage of fledge testing I assumed that it is available.
Bests,
Michal
The text was updated successfully, but these errors were encountered: