Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Web.md, instantiateStreaming shouldn't do instantiation in processingSteps #1131

Closed
lukewagner opened this issue Sep 26, 2017 · 2 comments

Comments

@lukewagner
Copy link
Member

(Just a spec-level bug, I think.) Instantiation is inherently realm-specific and must be given an imports object and so can't happen in the parallel, realm-agnostic processingSteps of Process a potential WebAssembly response in Web.md. Rather, I think compileStreaming and instantiateStreaming should have the same processingSteps (thus removing the need for processingSteps altogether) and instantiateStreaming should do instantiation in its successSteps. CC @littledan since probably we can just get this right in the new bikeshed spec which will subsume and replace Web.md.

@littledan
Copy link

This is fixed in the current Web.bs draft, see WebAssembly/spec#591

@lukewagner
Copy link
Member Author

Thanks, looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants