From cf0fb94aaed05fc4488f0f0fb8ebe5eda8ebc9a2 Mon Sep 17 00:00:00 2001 From: Greg Littlefield Date: Mon, 22 Apr 2019 17:31:05 -0700 Subject: [PATCH 1/2] Downgrade parse error to fine so as to not fail build unnecessarily If they're problematic, these errors will be handled further down the line (e.g., build_web_compilers). This prevents syntax errors in examples from failing test compilation. --- lib/src/builder/builder.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/src/builder/builder.dart b/lib/src/builder/builder.dart index 91d6a8a7f..9c8a28ada 100644 --- a/lib/src/builder/builder.dart +++ b/lib/src/builder/builder.dart @@ -111,7 +111,7 @@ class OverReactBuilder extends Builder { suppressErrors: false, parseFunctionBodies: true); } catch (error, stackTrace) { - log.severe('There was an error parsing the compilation unit for file: $id'); + log.fine('There was an error parsing the compilation unit for file: $id'); log.fine(error); log.fine(stackTrace); return null; @@ -139,4 +139,4 @@ class OverReactBuilder extends Builder { final output = _formatter.format(buffer.toString()); await buildStep.writeAsString(outputId, output); } -} \ No newline at end of file +} From eda35f9ce3e1e1e684a36f59b374b73f27a68e06 Mon Sep 17 00:00:00 2001 From: Greg Littlefield Date: Tue, 23 Apr 2019 11:47:03 -0700 Subject: [PATCH 2/2] Update generated code --- .../redux_component_test/test_reducer.g.dart | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/over_react/component_declaration/redux_component_test/test_reducer.g.dart b/test/over_react/component_declaration/redux_component_test/test_reducer.g.dart index 43a6321f9..fa830b482 100644 --- a/test/over_react/component_declaration/redux_component_test/test_reducer.g.dart +++ b/test/over_react/component_declaration/redux_component_test/test_reducer.g.dart @@ -42,7 +42,7 @@ class _$BaseState extends BaseState { @override final int count2; - factory _$BaseState([void updates(BaseStateBuilder b)]) => + factory _$BaseState([void Function(BaseStateBuilder) updates]) => (new BaseStateBuilder()..update(updates)).build(); _$BaseState._({this.count1, this.count2}) : super._() { @@ -55,7 +55,7 @@ class _$BaseState extends BaseState { } @override - BaseState rebuild(void updates(BaseStateBuilder b)) => + BaseState rebuild(void Function(BaseStateBuilder) updates) => (toBuilder()..update(updates)).build(); @override @@ -114,7 +114,7 @@ class BaseStateBuilder implements Builder { } @override - void update(void updates(BaseStateBuilder b)) { + void update(void Function(BaseStateBuilder) updates) { if (updates != null) updates(this); }