Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No binary rippled is produced even though build successful (Version: 2.3.0) #5205

Closed
exp0nge opened this issue Nov 26, 2024 · 2 comments
Closed

Comments

@exp0nge
Copy link

exp0nge commented Nov 26, 2024

Issue Description

The rippled binary is not produced on version 2.3.0:

(.venv) root@52b6745d7203:/rippled/.build# ls -la
total 197820
drwxr-xr-x  6 root root      4096 Nov 26 15:13 .
drwxr-xr-x 14 root root      4096 Nov 26 15:04 ..
-rw-r--r--  1 root root    747572 Nov 26 15:13 .ninja_deps
-rw-r--r--  1 root root     21395 Nov 26 15:13 .ninja_log
-rw-r--r--  1 root root     32777 Nov 26 15:13 CMakeCache.txt
drwxr-xr-x  7 root root      4096 Nov 26 15:13 CMakeFiles
-rw-r--r--  1 root root      2878 Nov 26 15:04 RippleConfigVersion.cmake
drwxr-xr-x  3 root root      4096 Nov 26 15:04 build
-rw-r--r--  1 root root    379159 Nov 26 15:13 build.ninja
-rw-r--r--  1 root root      5241 Nov 26 15:04 cmake_install.cmake
-rw-r--r--  1 root root     22104 Nov 26 15:13 conan.lock
-rw-r--r--  1 root root     28018 Nov 26 15:04 conanbuildinfo.txt
-rw-r--r--  1 root root      8911 Nov 26 15:13 conaninfo.txt
drwxr-xr-x  4 root root      4096 Nov 26 15:04 external
-rw-r--r--  1 root root     11011 Nov 26 15:13 graph_info.json
-rw-r--r--  1 root root 183503736 Nov 26 15:05 libxrpl.a
-rw-r--r--  1 root root  17755526 Nov 26 15:04 libxrpl.libpb.a
drwxr-xr-x  3 root root      4096 Nov 26 15:04 pb-xrpl.libpb

Steps to Reproduce

We use Docker:

# CMAKE, Conan
RUN curl --location --remote-name "https://github.com/Kitware/CMake/releases/download/v3.25.1/cmake-3.25.1.tar.gz" && \
  tar -xzf cmake-3.25.1.tar.gz && \
  rm cmake-3.25.1.tar.gz && \
  cd cmake-3.25.1 && \
  ./bootstrap --parallel=$(nproc) && \
  make --jobs $(nproc) && \
  make install && \
  cd .. && \
  python3 -m venv .venv && \
  . .venv/bin/activate && \
  pip3 install 'conan<2' && \
    conan profile new default --detect && \
    conan profile update settings.compiler.cppstd=20 default && \
    conan config set general.revisions_enabled=1 && \
    conan profile update settings.compiler.libcxx=libstdc++11 default && \
    conan remote update conancenter https://center.conan.io False && \
    conan profile update 'conf.tools.build:cxxflags+=["-DBOOST_BEAST_USE_STD_STRING_VIEW"]' default && \
    conan profile update 'env.CXXFLAGS="-DBOOST_BEAST_USE_STD_STRING_VIEW"' default


# rippled
ENV CMAKE_BUILD_PARALLEL_LEVEL=8
RUN . .venv/bin/activate && \
    git clone --depth=1 -b ${VERSION} https://github.com/XRPLF/rippled && \
    cd rippled && \
    mkdir .build && \
    cd .build && \
    conan config set general.cmake_generator=Ninja && \
    conan install .. --output-folder . --build missing --settings build_type=Release && \
    cmake -G Ninja -DCMAKE_TOOLCHAIN_FILE:FILEPATH=build/generators/conan_toolchain.cmake -DCMAKE_BUILD_TYPE=Release .. && \
    cmake --build . --config Release && \
    ./rippled --unittest && \
    cd ..

Expected Result

Actual Result

Environment

Supporting Files

@exp0nge
Copy link
Author

exp0nge commented Nov 26, 2024

OK 🤦 maybe it's this? #5052

@exp0nge exp0nge closed this as completed Nov 26, 2024
@mvadari
Copy link
Collaborator

mvadari commented Dec 2, 2024

Here's my cmake command:

cmake -DCMAKE_TOOLCHAIN_FILE:FILEPATH=build/generators/conan_toolchain.cmake -DCMAKE_BUILD_TYPE=Debug -Dxrpld=true -Dtests=true path/to/rippled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants