You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should we be disallowing certain passed-in arguments in this form? In my mind, the decorator form doesn't make any sense for zipkin_attrs or annotations, as these should change on a per-call basis. You're probably never going to want to log span after span with, say, the same trace_id, or the same timestamped annotations.
We could check for self.zipkin_attrs and raise an exception if a zipkin_span with these set is used in a decorator fashion.
Just a thought.
The notable arguments are zipkin_attrs and annotations. We should investigate which arguments are intended to be used with the zipkin_span decorator, and see if we can do something about it
The text was updated successfully, but these errors were encountered:
@mjbryant says in #21:
The notable arguments are
zipkin_attrs
andannotations
. We should investigate which arguments are intended to be used with thezipkin_span
decorator, and see if we can do something about itThe text was updated successfully, but these errors were encountered: