Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the zipkin_span decorator may allow too many arguments #22

Open
ericchu94 opened this issue Nov 4, 2016 · 0 comments
Open

the zipkin_span decorator may allow too many arguments #22

ericchu94 opened this issue Nov 4, 2016 · 0 comments

Comments

@ericchu94
Copy link
Contributor

@mjbryant says in #21:

Should we be disallowing certain passed-in arguments in this form? In my mind, the decorator form doesn't make any sense for zipkin_attrs or annotations, as these should change on a per-call basis. You're probably never going to want to log span after span with, say, the same trace_id, or the same timestamped annotations.

We could check for self.zipkin_attrs and raise an exception if a zipkin_span with these set is used in a decorator fashion.

Just a thought.

The notable arguments are zipkin_attrs and annotations. We should investigate which arguments are intended to be used with the zipkin_span decorator, and see if we can do something about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant