Skip to content

Commit 9f1ee81

Browse files
Akshay ChitneniGitHub Enterprise
Akshay Chitneni
authored and
GitHub Enterprise
committed
session deletion with culling (jupyter-server#387)
1 parent b62b9d9 commit 9f1ee81

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

data_studio_jupyter_extensions/configurables/kernel_monitor.py

+9-4
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,9 @@ async def poll(self):
110110
km = self.kernel_manager
111111

112112
if self.is_culling_enabled():
113-
await self.cull_if_idle()
114-
return
113+
culled = await self.cull_if_idle()
114+
if culled:
115+
return
115116

116117
# If the kernel is communicating, we're good here.
117118
if km.is_communicating():
@@ -160,7 +161,7 @@ def is_culling_enabled(self) -> bool:
160161
"""
161162
return self.cull_idle_timeout > 0
162163

163-
async def cull_if_idle(self):
164+
async def cull_if_idle(self) -> bool:
164165
"""Cull kernel if inactive."""
165166
km = self.kernel_manager
166167
dt_now = utcnow()
@@ -181,5 +182,9 @@ async def cull_if_idle(self):
181182
)
182183
# self._emit_console("Culling", msg) ## TODO: relay culled msg to user
183184
self.log.info(msg)
185+
await km.shutdown_kernel()
186+
self._fire_callbacks("dead")
184187
self.stop()
185-
await km.shutdown_kernel() ## TODO: clear sessionInfo for this kernel
188+
return True
189+
else:
190+
return False

0 commit comments

Comments
 (0)