Skip to content

Commit 5f9bd68

Browse files
committed
feat(loan-offer): pre production cleanup
1 parent f05ec60 commit 5f9bd68

File tree

3 files changed

+9
-22
lines changed

3 files changed

+9
-22
lines changed

src/services/BaseService.ts

+2-5
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import axios, { AxiosError, AxiosInstance } from 'axios'
22
import { isValidChecksumAddress } from 'ethereumjs-util'
33
import { ResponseCodes, ServiceErrorInstance, LoanMetadata, LoanAPIInstanceBase } from '../types'
4-
import { Transaction } from 'web3/eth/types';
54

65
class ServiceError extends Error implements ServiceErrorInstance {
76
public code: ResponseCodes
@@ -15,9 +14,8 @@ export default class BaseService {
1514
protected readonly api: AxiosInstance
1615
protected readonly serviceUrlRoot: string
1716

18-
constructor(serviceUrlRoot : string, token: string, apiUrl?: string ) {
19-
20-
this.serviceUrlRoot = serviceUrlRoot;
17+
constructor(serviceUrlRoot: string, token: string, apiUrl?: string) {
18+
this.serviceUrlRoot = serviceUrlRoot
2119
this.api = axios.create({
2220
baseURL: apiUrl || 'https://apikovan.aave.com/',
2321
headers: { Authorization: `Bearer ${token}` }
@@ -65,5 +63,4 @@ export default class BaseService {
6563
throw BaseService.errorHandler(e, resourceType, errorParam)
6664
}
6765
}
68-
6966
}

src/services/LoanOffer.ts

+4-11
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { Transaction } from 'web3/eth/types'
22

3-
import { LoanOfferAPIInstance, LoanOfferModel, LoanMetadata, BaseLoanModel } from '../types'
3+
import { LoanOfferAPIInstance, LoanOfferModel } from '../types'
44
import BaseService from './BaseService'
5-
import BaseLoanService from './BaseLoanService';
5+
import BaseLoanService from './BaseLoanService'
66

77
export default class LoanOffer extends BaseLoanService implements LoanOfferAPIInstance {
88
constructor(token: string, apiUrl?: string) {
9-
super('/offer',token, apiUrl)
9+
super('/offer', token, apiUrl)
1010
}
1111

1212
public async create(lenderAddress: string, params: LoanOfferModel): Promise<Transaction> {
@@ -33,13 +33,7 @@ export default class LoanOffer extends BaseLoanService implements LoanOfferAPIIn
3333
public async takeLoanOffer(loanAddress: string, params: LoanOfferModel): Promise<Transaction> {
3434
BaseService.checkAddressChecksum(loanAddress)
3535

36-
return await this.apiRequest(
37-
`/take/${loanAddress}`,
38-
'placing loan offer funds',
39-
loanAddress,
40-
'post',
41-
params
42-
)
36+
return await this.apiRequest(`/take/${loanAddress}`, 'placing loan offer funds', loanAddress, 'post', params)
4337
}
4438

4539
public async getLoanData(loanAddress: string): Promise<LoanOfferModel> {
@@ -67,5 +61,4 @@ export default class LoanOffer extends BaseLoanService implements LoanOfferAPIIn
6761

6862
return await Promise.all(allDataPromises)
6963
}
70-
7164
}

src/services/LoanRequest.ts

+3-6
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { Transaction } from 'web3/eth/types'
22

3-
import { LoanRequestAPIInstance, BaseLoanModel, LoanRequestModel, LoanMetadata } from '../types'
3+
import { LoanRequestAPIInstance, LoanRequestModel } from '../types'
44
import BaseService from './BaseService'
5-
import BaseLoanService from './BaseLoanService';
5+
import BaseLoanService from './BaseLoanService'
66

77
export default class LoanRequest extends BaseLoanService implements LoanRequestAPIInstance {
88
constructor(token: string, apiUrl?: string) {
9-
super('/request',token, apiUrl)
9+
super('/request', token, apiUrl)
1010
}
1111

1212
public async create(borrowerWalletAddress: string, params: LoanRequestModel): Promise<Transaction> {
@@ -42,7 +42,6 @@ export default class LoanRequest extends BaseLoanService implements LoanRequestA
4242
)
4343
}
4444

45-
4645
public async getLoanData(loanAddress: string): Promise<LoanRequestModel> {
4746
BaseService.checkAddressChecksum(loanAddress)
4847

@@ -60,7 +59,6 @@ export default class LoanRequest extends BaseLoanService implements LoanRequestA
6059
return await Promise.all(allDataPromises)
6160
}
6261

63-
6462
public async getDataAllLoansByBorrower(borrowerAddress: string): Promise<LoanRequestModel[]> {
6563
const requestAddressesBorrower = await this.getLoansByBorrower(borrowerAddress)
6664
const allDataPromises = requestAddressesBorrower.map(address => this.getLoanData(address))
@@ -74,5 +72,4 @@ export default class LoanRequest extends BaseLoanService implements LoanRequestA
7472

7573
return await Promise.all(allDataPromises)
7674
}
77-
7875
}

0 commit comments

Comments
 (0)