Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llama_cpp.llama_sample_top_k(self.ctx, candidates_p, top_k, min_keep=32) #185

Closed
lucasjinreal opened this issue May 11, 2023 · 2 comments · May be fixed by #631
Closed

llama_cpp.llama_sample_top_k(self.ctx, candidates_p, top_k, min_keep=32) #185

lucasjinreal opened this issue May 11, 2023 · 2 comments · May be fixed by #631
Labels
documentation Improvements or additions to documentation llama.cpp Problem with llama.cpp shared lib

Comments

@lucasjinreal
Copy link

llama_cpp.llama_sample_top_k(self.ctx, candidates_p, top_k, min_keep=32)

this function in example lack of min_keep params, what's default value of this?
@SagsMug
Copy link
Contributor

SagsMug commented May 11, 2023

Yeah, ggml-org/llama.cpp#1343 broke it
It's default value is 1

@gjmulder gjmulder added documentation Improvements or additions to documentation llama.cpp Problem with llama.cpp shared lib labels May 12, 2023
@gjmulder
Copy link
Contributor

Any update?

@abetlen abetlen mentioned this issue Sep 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation llama.cpp Problem with llama.cpp shared lib
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add beam search heavyai/llama-cpp-python
3 participants
@SagsMug @gjmulder @lucasjinreal