Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import path should be "github.com/sirupsen/logrus", not "github.com/Sirupsen/logrus" #31

Open
KateGo520 opened this issue Aug 6, 2020 · 1 comment

Comments

@KateGo520
Copy link

KateGo520 commented Aug 6, 2020

Background

I find that github.com/sirupsen/logrus and github.com/Sirupsen/logrus coexist in this repo:
Gopkg.toml

[[constraint]]
  name = "github.com/Sirupsen/logrus"
  version = "1.4.2"

[[constraint]]
  branch = "master"
  name = "github.com/influxdata/influxdb1-client"

[[constraint]]
  name = "github.com/sirupsen/logrus"
  version = "1.4.2"

Some places used github.com/Sirupsen/logrus. Some places used github.com/sirupsen/logrus. But github.com/sirupsen/logrus and github.com/Sirupsen/logrus are the same repo.
As README of logrus said, github.com/Sirupsen/logrus is the old path, anything using it should be updated to import and require github.com/sirupsen/logrus.

Some environments experienced problems with the upper-case variant, so the lower-case was decided. Everything using logrus will need to use the lower-case: github.com/sirupsen/logrus. Any package that isn't, should be changed.

Solution

Replace all the import paths, change "github.com/Sirupsen/logrus" to "github.com/sirupsen/logrus".
Where did you import it: https://github.com/abramovic/logrus_influxdb/search?q=github.com%2FSirupsen%2Flogrus&unscoped_q=github.com%2FSirupsen%2Flogrus

@KateGo520
Copy link
Author

KateGo520 commented Aug 6, 2020

@abramovic @davidq2q Could you help me review this issue? Thx :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant