Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animal Sets (groups) membership change events #139

Closed
cookeac opened this issue Aug 17, 2020 · 1 comment · Fixed by #141
Closed

Animal Sets (groups) membership change events #139

cookeac opened this issue Aug 17, 2020 · 1 comment · Fixed by #141
Labels
this-release Scheduled to be implemented for this release in development

Comments

@cookeac
Copy link
Collaborator

cookeac commented Aug 17, 2020

After implementing icarAnimalSetResource (issues #88) we thought it would be useful to have events that could record the date at which an animal joined or entered a set, and left/was removed from a set.

As with our other events, these should probably be animal-oriented (events based on the Animal ID) and reference the set.
For example:

  • icarSetArrivalEventResource and
  • icarSetDepartureEventResource
@cookeac cookeac added the this-release Scheduled to be implemented for this release in development label Aug 17, 2020
@ghost
Copy link

ghost commented Aug 21, 2020

@MarvinGEA and I created a pull request that adds animalSetJoin and animalSetLeave events.

While implementing this we were wondering whether a "animalSetChangeEvent" would be more appropriate for some use cases. However, this event would then be the first one to not reference a single animal.

@cookeac cookeac linked a pull request Aug 27, 2020 that will close this issue
@cookeac cookeac closed this as completed Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
this-release Scheduled to be implemented for this release in development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant